Skip to content

Update CHANGES.txt to reflect my optimization PR 15637#15699

Closed
countmdm wants to merge 1 commit intoapache:mainfrom
countmdm:update-changes_txt_STEF2
Closed

Update CHANGES.txt to reflect my optimization PR 15637#15699
countmdm wants to merge 1 commit intoapache:mainfrom
countmdm:update-changes_txt_STEF2

Conversation

@countmdm
Copy link
Contributor

Description

Update CHANGES.txt as requested by reviewers of my PR 15637.

@github-actions github-actions bot added this to the 10.4.0 milestone Feb 11, 2026
@shubhamsrkdev
Copy link
Contributor

I think there is already a CHANGES.txt entry (targeting 10.5) for #15637 . I think @dweiss added it for your PR?

@countmdm
Copy link
Contributor Author

I think there is already a CHANGES.txt entry (targeting 10.5) for #15637 . I think @dweiss added it for your PR?

I am somewhat confused by how to keep track of all Lucene branches. But to the best of my knowledge, no, there is no entry for #15637. @dweiss once added an entry for my previous PR, #15618 .

@dweiss
Copy link
Contributor

dweiss commented Feb 12, 2026

You should add a changes entry to the section/ version against which the patch is targeted, for example:
https://github.com/apache/lucene/blob/main/lucene/CHANGES.txt#L196

This is applied to branch_10x, then forward-ported to main (or applied to main and then backported to 10x) but it'll be consistent on both.

@countmdm
Copy link
Contributor Author

You should add a changes entry to the section/ version against which the patch is targeted, for example: https://github.com/apache/lucene/blob/main/lucene/CHANGES.txt#L196

This is applied to branch_10x, then forward-ported to main (or applied to main and then backported to 10x) but it'll be consistent on both.

Ok, I see. The CHANGES.txt file on the above link has a "Lucene 10.5.0" section. However, on my local main branch, this file only has "Lucene 11.0" and "Lucene 10.4.0" sections.

You should add a changes entry to the section/ version against which the patch is targeted, for example: https://github.com/apache/lucene/blob/main/lucene/CHANGES.txt#L196

This is applied to branch_10x, then forward-ported to main (or applied to main and then backported to 10x) but it'll be consistent on both.

Oh, ok, sorry about myself being dumb, I forgot to update my Lucene fork :) Now I see that there is already a proper entry in CHANGES.txt for #15637 . So closing this PR.

@countmdm countmdm closed this Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants