Replace LinkedDictionary with OrderedDictionary#1200
Merged
paulirwin merged 1 commit intoapache:masterfrom Oct 4, 2025
Merged
Conversation
Replaced all usages of JCG.LinkedDictionary with JCG.OrderedDictionary across the codebase for consistency and to better match the semantics of LinkedHashMap in the JDK. Updated comments to clarify the change as Lucene.NET specific.
paulirwin
approved these changes
Oct 4, 2025
Contributor
paulirwin
left a comment
paulirwin
left a comment
There was a problem hiding this comment.
Thanks for the PR! This looks good.
Contributor
|
I just noticed that this is the same issue (#1199) that was assigned to @PrakhyaDas. I'm assuming you two are not the same person. @ksanjeev284 - Thank you for your contribution, but this might have caused duplicated effort, since the work item was assigned to @PrakhyaDas first. I am going to merge this PR this time, but going forward please check to see if the issue is assigned to someone before working on it or submitting a PR. @PrakhyaDas - My apologies for this mixup. I hope you'll be interested in contributing to another one of our issues. Please let me know if you need guidance on choosing one! Thanks again. |
Contributor
Author
|
Sure @paulirwin, I will make sure to check next time |
1 task
NightOwl888
added
notes:breaking-change
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1199
Description
Replaced all usages of JCG.LinkedDictionary with JCG.OrderedDictionary across the codebase for consistency and to better match the semantics of LinkedHashMap in the JDK. Updated comments to clarify the change as Lucene.NET specific.