Lucene.Net.Store (DataInput + DataOutput): Use stack or array pool for temporary byte buffers#1207
Merged
paulirwin merged 4 commits intoapache:masterfrom Nov 22, 2025
Conversation
NightOwl888
added
the
notes:performance-improvement
paulirwin
approved these changes
Oct 6, 2025
Contributor
paulirwin
left a comment
paulirwin
left a comment
There was a problem hiding this comment.
This looks good to me. My only comment is that in general, I think these methods could use unit tests.
Contributor
|
@NightOwl888 Would you like my assistance on adding unit tests for these methods? |
Contributor
Author
|
@paulirwin - Sure, that would be helpful. Thanks. |
…rray pool for buffer reuse
…cepts spans for both input and output. Also added a GetMaxByteCount() method to determine the amount of buffer to allocate.
…hars() method that accepts a span and moved allocations to the stack or array pool for buffer reuse.
paulirwin
force-pushed
the
perf/datainput-dataoutput-strings
branch
from
770548c to
43802aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lucene.Net.Store (DataInput + DataOutput):Use stack or array pool for temporary byte buffersDescription
This optimizes the temporary buffers used when converting between UTF16 and UTF8 by putting them on the stack with fallback to the array pool for large strings.
Benchmarks
I increased the payload to 100 string fields per document (a GUID value) and this was the result. The biggest impact is the amount allocated while writing an index.
Index Files
ReadStoredFields