Skip to content

avoid negative entry time: upgrade plexus-archiver #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2025
Merged

avoid negative entry time: upgrade plexus-archiver #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-archiver</artifactId>
<version>4.10.1</version>
<version>4.10.2</version>
</dependency>
<dependency>
<groupId>org.codehaus.plexus</groupId>
Expand Down
30 changes: 30 additions & 0 deletions src/test/java/org/apache/maven/shared/archiver/MavenArchiverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
import java.util.jar.Manifest;
import java.util.stream.Stream;
import java.util.zip.ZipEntry;
import java.util.zip.ZipFile;

import org.apache.maven.api.Dependency;
import org.apache.maven.api.DependencyCoordinates;
Expand Down Expand Up @@ -1385,4 +1386,33 @@ public void setPath(Path path) {
this.path = path;
}
}

private long testReproducibleJarEntryTime(String name, String timestamp) throws Exception {
File jarFile = new File("target/test/dummy-" + name + ".jar");

MavenArchiver archiver = getMavenArchiver(getCleanJarArchiver(jarFile));
archiver.configureReproducibleBuild(timestamp);
archiver.createArchive(getDummySession(), getDummyProject(), new MavenArchiveConfiguration());

assertThat(jarFile).exists();
ZipFile zf = new ZipFile(jarFile);
ZipEntry ze = zf.getEntry("META-INF/MANIFEST.MF");
return ze.getTime();
}

/**
* before upgrading plexus archiver to 4.10.2 to benefit from https://github.com/codehaus-plexus/plexus-archiver/pull/388
* $ zipdetails target/test/dummy-1970.jar
* gives negative Extended Timestamp in Java, that is seen as some point in time in 2106 (zip spec is unsigned)
* 0027 Extra ID #0001 5455 'UT: Extended Timestamp'
* 0029 Length 0005
* 002B Flags '01 mod'
* 002C Mod Time FFFFF1FA 'Sun Feb 7 06:28:26 2106'
* @throws Exception
*/
@Test
void testReproducibleJar19700101() throws Exception {
long entryTime = testReproducibleJarEntryTime("1970", "10");
assertThat(entryTime).isGreaterThanOrEqualTo(0);
}
}