Skip to content

Conversation

@algomaster99
Copy link

@algomaster99 algomaster99 commented Oct 20, 2025

Following this checklist to help us incorporate your
contribution quickly and easily:

This PR backports changes did for reproducibility in #79. It ensures that properties in pom.properties are sorted. Sorting of properties is already implemented in JDK 18 but it is also nice to have at the Maven plugin level.

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@algomaster99
Copy link
Author

I have to fix some compilation issues which I will take a look at later.

Co-authored-by: Elliotte Rusty Harold <[email protected]>
Co-authored-by: Guillaume Nodet <[email protected]>
@algomaster99 algomaster99 force-pushed the backport-property-sorting branch from 3cced3b to 79d93eb Compare October 31, 2025 16:53
@algomaster99 algomaster99 marked this pull request as ready for review October 31, 2025 17:10
@algomaster99
Copy link
Author

@hboutemy here is the backported patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant