[MCOMPILER-1006] Fix <proc>only</proc> not triggering annotation processors #1017
+43
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #1006, where the Maven Compiler Plugin did not execute annotation processors properly when
<proc>only</proc>was set. Previously, the plugin exited early with the message "Nothing to compile - all classes are up to date," which stopped annotation processors from running.Changes
execute()method to make sure that when<proc>only</proc>is set, the compiler runs even if no Java source files have changed.Rationale
Annotation processors like Log4j’s
PluginProcessormust run independently of source compilation. This change makes the plugin behave likejavac -proc:onlyand clears up confusion from misleading log messages.Impact
<proc>only</proc>.Verification
target/generated-sources/annotations.mvn -Prun-its verify.Please review and let me know if you want me to add an integration test for this specific use case.