Introduce graphRoots for dependencyFilter based mojos #1571

rfscholte · 2025-12-29T12:36:11Z

Following this checklist to help us incorporate your
contribution quickly and easily:

Your pull request should address just one issue, without pulling in other changes.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Each commit in the pull request should have a meaningful subject line and body.
Note that commits might be squashed by a maintainer on merge.
Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
Run mvn verify to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.

.../java/org/apache/maven/plugins/dependency/fromDependencies/AbstractDependencyFilterMojo.java

mthmulders · 2026-01-05T11:03:27Z

.../java/org/apache/maven/plugins/dependency/fromDependencies/AbstractDependencyFilterMojo.java

+        List<RemoteRepository> remoteRepositories =
+                RepositoryUtils.toRepos(session.getProjectBuildingRequest().getRemoteRepositories());
+
+        Collection<org.eclipse.aether.artifact.Artifact> depArtifacts =


To clarify: we do full (transitive) dependency resolution only when the user specified one or more graphRoots, but not when the project itself is the graphRoot. Does that make sense?

The project dependencies have already been resolved, as the goal of the final Mojo contains requiresDependencyResolution = ResolutionScope.TEST. So it is actually re-resolving the dependencies. The MavenProject doesn't provide the graph, hence the need ask for the graph user maven artifact resolver.

I get it. Maybe worth copying that text to an inline comment, in order to prevent future maintainers from asking themselves why the code is there.

mthmulders · 2026-01-05T11:05:49Z

src/main/java/org/apache/maven/plugins/dependency/fromDependencies/GraphRoot.java

+package org.apache.maven.plugins.dependency.fromDependencies;
+
+/**
+ * All values are static, no expression, so matcher can use equals


But the matcher does not use equals()?

This is a good question. My first approach was to make these values Nullable: if not specified it is a match. However while working with it (and as confirmed in the integration-test) it is probably better to be explicit. Just always specify groupId and artifactId, and type if it is not a jar, just as explicit as the dependency. WDYT?

I would certainly prefer to make it explicit, and not give null the magical meaning of "could be anything" or "don't care".

Just always specify groupId and artifactId, and type if it is not a jar, just as explicit as the dependency.

You mean: actual matching is as explicit as the graphRoot declaration in the plugin configuration?

A small rewrite, you know must define the graphRoot's groupId and artifactId matching the targeted dependency. I've removed the type, because only the main artifact can have dependencies (classified like javadoc and sources don't have dependencies) and the pom can only point to 1 main artifact via packaging. I don't expect a request for support of type, but if so it should be solved separately. It is probably tricky if 2 main artifacts share the same pom.

mthmulders · 2026-01-05T11:07:44Z

src/main/java/org/apache/maven/plugins/dependency/fromDependencies/GraphRootMatcher.java

+
+    @Override
+    public boolean matches(Dependency dependency) {
+        return matches(graphRoot.getGroupId(), dependency.getGroupId())


I think you could've used Objects.equals() here - it's available since Java 1.7, according to its Javadoc.

The previous comment. If graphroot is explicit, this matches can be removed.

I've decided to keep this class, as we're trying to match 2 different kind of classes. null-ignoring matches method has been replaced.

src/site/apt/examples/copying-project-dependencies.apt.vm

src/it/projects/copy-dependencies-graphroots/pom.xml

mthmulders · 2026-01-05T11:13:05Z

src/main/java/org/apache/maven/plugins/dependency/fromDependencies/OrDependencyMatcher.java

+
+import org.apache.maven.model.Dependency;
+
+class OrDependencyMatcher implements DependencyMatcher {


Personally, I would've added unit tests for this class.

mthmulders · 2026-01-05T11:13:57Z

src/main/java/org/apache/maven/plugins/dependency/fromDependencies/GraphRootMatcher.java

+
+import org.apache.maven.model.Dependency;
+
+class GraphRootMatcher implements DependencyMatcher {


Personally, I would've added unit tests for this class.

…cies/AbstractDependencyFilterMojo.java Co-authored-by: Maarten Mulders <[email protected]>

Co-authored-by: Maarten Mulders <[email protected]>

slawekjaranowski · 2026-01-11T09:14:49Z

.../java/org/apache/maven/plugins/dependency/fromDependencies/AbstractDependencyFilterMojo.java

+     * @since 3.10.0
+     */
+    @Parameter
+    private List<GraphRoot> graphRoots;


As GraphRoot is an complex object we can provide an example in documentation to be clear how to use in configuration

slawekjaranowski · 2026-01-11T09:18:54Z

.../java/org/apache/maven/plugins/dependency/fromDependencies/AbstractDependencyFilterMojo.java

+                root, session.getRepositorySession().getArtifactTypeRegistry());
+
+        List<RemoteRepository> remoteRepositories =
+                RepositoryUtils.toRepos(session.getProjectBuildingRequest().getRemoteRepositories());


There is MavenProject#getRemoteProjectRepositories

Introduce graphRoots for dependencyFilter based mojos

0bb8bd3

rfscholte requested a review from mthmulders December 29, 2025 12:36

mthmulders reviewed Jan 5, 2026

View reviewed changes

rfscholte and others added 5 commits January 5, 2026 20:02

Update src/main/java/org/apache/maven/plugins/dependency/fromDependen…

217a0b1

…cies/AbstractDependencyFilterMojo.java Co-authored-by: Maarten Mulders <[email protected]>

Update src/site/apt/examples/copying-project-dependencies.apt.vm

be1f53a

Co-authored-by: Maarten Mulders <[email protected]>

Update src/it/projects/copy-dependencies-graphroots/pom.xml

1824a93

Co-authored-by: Maarten Mulders <[email protected]>

add extra graphnode to confirm it can handle a list

8b27e36

extra comments and tests based on review

ffba5a6

mthmulders approved these changes Jan 9, 2026

View reviewed changes

slawekjaranowski reviewed Jan 11, 2026

View reviewed changes

slawekjaranowski approved these changes Jan 11, 2026

View reviewed changes


		import org.apache.maven.model.Dependency;

		class OrDependencyMatcher implements DependencyMatcher {


		import org.apache.maven.model.Dependency;

		class GraphRootMatcher implements DependencyMatcher {

Introduce graphRoots for dependencyFilter based mojos #1571

Are you sure you want to change the base?

Introduce graphRoots for dependencyFilter based mojos #1571

Conversation

rfscholte commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rfscholte commented Dec 29, 2025 •

edited

Loading