Skip to content

Expected value comes first in JUnit #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Expected value comes first in JUnit #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f463e6d
Expected value comes first in JUnit
elharo Feb 23, 2025
3ec2f84
spotless
elharo Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/test/java/org/apache/maven/plugins/deploy/DeployFileMojoTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,6 @@ public void testDeployIfClassifierIsSet(DeployFileMojo mojo) throws Exception {
assertEquals("bin", classifier);
String version = (String) getVariableValueFromObject(mojo, "version");
String url = (String) getVariableValueFromObject(mojo, "url");

execute(mojo, request -> {
assertNotNull(request);
List<Artifact> artifacts = new ArrayList<>(request.getArtifacts());
Expand Down
18 changes: 9 additions & 9 deletions src/test/java/org/apache/maven/plugins/deploy/DeployMojoTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,10 +199,10 @@ public void testLegacyAltDeploymentRepositoryWithLegacyLayout(DeployMojo mojo) t
MojoException.class,
() -> mojo.getDeploymentRepository(true),
"Should throw: Invalid legacy syntax and layout for repository.");
assertEquals(e.getMessage(), "Invalid legacy syntax and layout for repository.");
assertEquals("Invalid legacy syntax and layout for repository.", e.getMessage());
assertEquals(
e.getLongMessage(),
"Invalid legacy syntax and layout for alternative repository. Use \"altDeploymentRepository::http://localhost\" instead, and only default layout is supported.");
"Invalid legacy syntax and layout for alternative repository. Use \"altDeploymentRepository::http://localhost\" instead, and only default layout is supported.",
e.getLongMessage());
}

@Test
Expand All @@ -215,10 +215,10 @@ public void testInsaneAltDeploymentRepository(DeployMojo mojo) throws IllegalAcc
MojoException.class,
() -> mojo.getDeploymentRepository(true),
"Should throw: Invalid legacy syntax and layout for repository.");
assertEquals(e.getMessage(), "Invalid legacy syntax and layout for repository.");
assertEquals("Invalid legacy syntax and layout for repository.", e.getMessage());
assertEquals(
e.getLongMessage(),
"Invalid legacy syntax and layout for alternative repository. Use \"altDeploymentRepository::wow::foo::http://localhost\" instead, and only default layout is supported.");
"Invalid legacy syntax and layout for alternative repository. Use \"altDeploymentRepository::wow::foo::http://localhost\" instead, and only default layout is supported.",
e.getLongMessage());
}

@Test
Expand All @@ -242,10 +242,10 @@ public void testLegacyScmSvnAltDeploymentRepository(DeployMojo mojo) throws Ille
MojoException.class,
() -> mojo.getDeploymentRepository(true),
"Should throw: Invalid legacy syntax and layout for repository.");
assertEquals(e.getMessage(), "Invalid legacy syntax and layout for repository.");
assertEquals("Invalid legacy syntax and layout for repository.", e.getMessage());
assertEquals(
e.getLongMessage(),
"Invalid legacy syntax and layout for alternative repository. Use \"altDeploymentRepository::scm:svn:http://localhost\" instead, and only default layout is supported.");
"Invalid legacy syntax and layout for alternative repository. Use \"altDeploymentRepository::scm:svn:http://localhost\" instead, and only default layout is supported.",
e.getLongMessage());
}

@Test
Expand Down