Skip to content

clean up a few unthrown exceptions #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elharo merged 2 commits into from
Aug 21, 2025
+4 −6
Merged

clean up a few unthrown exceptions #1232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
994135a
clean up a few unthrown exceptions
elharo Aug 13, 2025
84da2d1
catch
elharo Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/main/java/org/apache/maven/plugins/javadoc/AbstractFixJavadocMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2412,9 +2412,8 @@ private boolean isNewClassFromLastVersion(JavaClass javaClass) {
* @param javaExecutable a given method not null
* @return <code>true</code> if Clirr said that this method is added from the last version,
* <code>false</code> otherwise or if {@link #clirrNewMethods} is null.
* @throws MojoExecutionException if any
*/
private boolean isNewMethodFromLastRevision(JavaExecutable javaExecutable) throws MojoExecutionException {
private boolean isNewMethodFromLastRevision(JavaExecutable javaExecutable) {
if (clirrNewMethods == null) {
return false;
}
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ protected static Collection<String> getExcludedPackages(
try {
Files.walkFileTree(sourceDirectory, new SimpleFileVisitor<Path>() {
@Override
public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) throws IOException {
public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) {
if (file.getFileName().toString().endsWith(".java")) {
fileList.add(
sourceDirectory.relativize(file.getParent()).toString());
Expand Down
5 changes: 2 additions & 3 deletions src/main/java/org/apache/maven/plugins/javadoc/resolver/ResourceResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ private List<JavadocBundle> resolveBundlesFromArtifacts(
Collection<Path> dirs = new ArrayList<>(toResolve.size());
try {
dirs = resolveAndUnpack(toResolve, config, RESOURCE_VALID_CLASSIFIERS, false);
} catch (ArtifactResolutionException | ArtifactNotFoundException e) {
} catch (ArtifactResolutionException e) {
if (LOGGER.isDebugEnabled()) {
LOGGER.debug(e.getMessage(), e);
}
Expand Down Expand Up @@ -289,14 +289,13 @@ private org.eclipse.aether.artifact.Artifact createResourceArtifact(
* @param propagateErrors
* @return list of <dependencyConflictId, absolutePath>
* @throws ArtifactResolutionException if an exception occurs
* @throws ArtifactNotFoundException if an exception occurs
*/
private Collection<Path> resolveAndUnpack(
final List<org.eclipse.aether.artifact.Artifact> artifacts,
final SourceResolverConfig config,
final List<String> validClassifiers,
final boolean propagateErrors)
throws ArtifactResolutionException, ArtifactNotFoundException {
throws ArtifactResolutionException {
// NOTE: Since these are '-sources' and '-test-sources' artifacts, they won't actually
// resolve transitively...this is just used to aggregate resolution failures into a single
// exception.
Expand Down
Loading