Skip to content

Ensure UTF-8 charset is used to avoid IllegalArgumentException: Null charset name #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olamy merged 4 commits into from
Aug 21, 2025
+46 −29
Merged

Ensure UTF-8 charset is used to avoid IllegalArgumentException: Null charset name #1245

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e951339
Specify UTF-8
elharo Aug 19, 2025
a5fdd59
use charset
elharo Aug 20, 2025
02710fd
move
elharo Aug 20, 2025
ad2d8e1
spotless
elharo Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5393,7 +5393,7 @@ private List<OfflineLink> getModulesLinks() throws MavenReportException {
} catch (MavenInvocationException e) {
logError("MavenInvocationException: " + e.getMessage(), e);

String invokerLogContent = JavadocUtil.readFile(invokerLogFile, null /* platform encoding */);
String invokerLogContent = JavadocUtil.readFile(invokerLogFile, "UTF-8");
Copy link

Copilot AI Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using StandardCharsets.UTF_8 instead of the string literal "UTF-8" to avoid potential typos and improve type safety.

Suggested change
String invokerLogContent = JavadocUtil.readFile(invokerLogFile, "UTF-8");
String invokerLogContent = JavadocUtil.readFile(invokerLogFile, StandardCharsets.UTF_8.name());

Copilot uses AI. Check for mistakes.
Copy link
Member

@olamy olamy Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to agree with the bot here.

Copy link

@wendigo wendigo Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other places like that


// TODO: Why are we only interested in cases where the JVM won't start?
// [MJAVADOC-275][jdcasey] I changed the logic here to only throw an error WHEN
Expand Down
Loading