-
Notifications
You must be signed in to change notification settings - Fork 103
detectOfflineLinks is now false per default for all *jar* mojo issue #1258 #1259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -176,6 +176,25 @@ public JavadocJarMojo( | |
| @Parameter(property = "maven.javadoc.classifier", defaultValue = "javadoc", required = true) | ||
| private String classifier; | ||
|
|
||
| /** | ||
| * Detect the links for all modules defined in the project. | ||
| * <br/> | ||
| * If {@code reactorProjects} is defined in a non-aggregator way, it generates default offline links | ||
| * between modules based on the defined project's urls. For instance, if a parent project has two projects | ||
olamy marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| * <code>module1</code> and <code>module2</code>, the <code>-linkoffline</code> will be: | ||
| * <br/> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| * The added Javadoc <code>-linkoffline</code> parameter for <b>module1</b> will be | ||
| * <code>/absolute/path/to/</code><b>module2</b><code>/target/site/apidocs</code> | ||
| * <br/> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| * The added Javadoc <code>-linkoffline</code> parameter for <b>module2</b> will be | ||
| * <code>/absolute/path/to/</code><b>module1</b><code>/target/site/apidocs</code> | ||
| * | ||
| * @see #offlineLinks | ||
| * @since 2.6 | ||
| */ | ||
| @Parameter(property = "detectOfflineLinks", defaultValue = "false") | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why is this here instead of the superclass?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. because the role of this change is to have a default of |
||
| private boolean detectOfflineLinks; | ||
|
|
||
| /** {@inheritDoc} */ | ||
| @Override | ||
| protected void doExecute() throws MojoExecutionException { | ||
|
|
@@ -290,4 +309,9 @@ private File generateArchive(File javadocFiles, String jarFileName) throws Archi | |
|
|
||
| return outputFile; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isDetectOfflineLinks() { | ||
| return detectOfflineLinks; | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.