Fix bug by using UTF-8 unconditionally #1276
Closed
+5
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
FYI, looks like the CI is borked again: The job is failing due to the error: This means the Groovy script (verify.groovy) is trying to load or interact with class files compiled for Java 23 (major version 69), but the version of Groovy used does not support this Java version. |
Contributor
Author
|
Might also be a problem involving directory name encoding |
Contributor
|
I verified it extensively and the bug I was fixing by #1215 is still fixed with this PR. So, at least from this point of view it looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maven should produce byte per byte identical output on different platforms. That means when writing text files it should not depend on the platform default character set.
fixes #1273
@jglick
@garydgegory
@fridrich
@ASDFGamer