Use spotless / palantirJavaFormat - 2.56.0 for all JDKs

[slawekjaranowski]

Spotless start using palantir-java-format 2.57.0 on Java 21 - on older jdks different versions are used.

It causes a different code format depends on using JDK

references:

• Use palantir-java-format 2.57.0 on Java 21 diffplug/spotless#2447
• Spotless formats code differently between JDK versions (17 vs 21) diffplug/spotless#2503
• extra indent in comments within switch - jdk 11 palantir/palantir-java-format#1320

As issue - diffplug/spotless#2503 was closed, reverting spotless plugin to an older version is not a resolution.

[slachiewicz]

I don't think this is the way to go as it doesn't support Java 25

[slawekjaranowski]

I don't think this is the way to go as it doesn't support Java 25

We don't have a Jave 25 code base yet ...

but we never version of formater we will have different format depends on JDK ...

[slawekjaranowski]

@slachiewicz any other proposition?

[slachiewicz]

Sorry, no idea yet. It's about Java 25 at runtime, IE even now, try to build our Core Maven

[slawekjaranowski]

Sorry, no idea yet. It's about Java 25 at runtime, IE even now, try to build our Core Maven

build ok
two unit test not pass due to not resolving snapshot version of parent

[slachiewicz]

`mvn -V spotless:check
Apache Maven 3.9.10 (5f519b97e944483d878815739f519b2eade0a91d)
Maven home: /opt/homebrew/Cellar/maven/3.9.10/libexec
Java version: 25-ea, vendor: Oracle Corporation, runtime: /Library/Java/JavaVirtualMachines/jdk-25.jdk/Contents/Home

[..]
[INFO] --- spotless:2.44.3:check (default-cli) @ maven-api ---
[INFO] Spotless.Pom is keeping 1 files clean - 0 needs changes to be clean, 0 were already clean, 1 were skipped because caching determined they were already clean
[INFO]
[INFO] ---------------< org.apache.maven:maven-api-annotations >---------------
[INFO] Building Maven 4 API :: Meta annotations 4.0.0-rc-4-SNAPSHOT [3/39]
[INFO] from api/maven-api-annotations/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- spotless:2.44.3:check (default-cli) @ maven-api-annotations ---
[ERROR] Step 'palantir-java-format' found problem in 'Nonnull.java':
'java.util.Queue com.sun.tools.javac.util.Log$DeferredDiagnosticHandler.getDiagnostics()'
java.lang.NoSuchMethodError: 'java.util.Queue com.sun.tools.javac.util.Log$DeferredDiagnosticHandler.getDiagnostics()'
at com.palantir.javaformat.java.JavaInput.buildToks (JavaInput.java:366)
at com.palantir.javaformat.java.ImportOrderer.reorderImports (ImportOrderer.java:49)
at com.diffplug.spotless.glue.pjf.PalantirJavaFormatFormatterFunc.apply (PalantirJavaFormatFormatterFunc.java:53)

`

[slawekjaranowski]

so with this change will be the same .... so will be not worst

[INFO] --- spotless:2.44.5:check (default-cli) @ maven-executor ---
[ERROR] Step 'palantir-java-format' found problem in 'ToolboxToolTest.java':
'java.util.Queue com.sun.tools.javac.util.Log$DeferredDiagnosticHandler.getDiagnostics()'
java.lang.NoSuchMethodError: 'java.util.Queue com.sun.tools.javac.util.Log$DeferredDiagnosticHandler.getDiagnostics()'

[slawekjaranowski]

when java-format will be fixed we will update in next time, for me there are two isses:

• fix: support JDK 25 API change palantir/palantir-java-format#1305
• extra indent in comments within switch - jdk 11 palantir/palantir-java-format#1320

[slawekjaranowski]

Now we can disable spotless at all on JDK 25+ as workaround, but if we wish such I would like do it in separate PR

[kwin]

Makes sense.

[slawekjaranowski]

@slachiewicz - properties for versions added