Skip to content

[MPLUGIN-522] Prerequisites should be opt-in #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[MPLUGIN-522] Prerequisites should be opt-in #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions maven-plugin-plugin/src/it/java-basic-annotations/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ under the License.
<configuration>
<skipErrorNoDescriptorsFound>true</skipErrorNoDescriptorsFound>
<goalPrefix>prefix</goalPrefix>
<requiredJavaVersion>auto</requiredJavaVersion>
<requiredMavenVersion>auto</requiredMavenVersion>
</configuration>
<executions>
<execution>
Expand Down
2 changes: 2 additions & 0 deletions maven-plugin-plugin/src/it/v4api/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ under the License.
<version>@project.version@</version>
<configuration>
<goalPrefix>prefix</goalPrefix>
<requiredJavaVersion>auto</requiredJavaVersion>
<requiredMavenVersion>auto</requiredMavenVersion>
</configuration>
<executions>
<execution>
Expand Down
6 changes: 4 additions & 2 deletions ...n-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/DescriptorGeneratorMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,11 +233,12 @@ public class DescriptorGeneratorMojo extends AbstractGeneratorMojo {
* form for {@code "[1.8,)"}, i.e. denotes the minimum version required.</li>
* <li>{@code "auto"} to determine the minimum Java version from the binary class version being generated during
* compilation (determined by the extractor).</li>
* <li>By default is not set.</li>
* </ul>
*
* @since 3.8.0
*/
@Parameter(defaultValue = VALUE_AUTO)
@Parameter
String requiredJavaVersion;

/**
Expand All @@ -250,13 +251,14 @@ public class DescriptorGeneratorMojo extends AbstractGeneratorMojo {
* form for {@code "[2.2.1,)"}, i.e. denotes the minimum version required.</li>
* <li>{@code "auto"} to determine the minimum Maven version from the POM's Maven prerequisite, or if not set the
* referenced Maven Plugin API version.</li>
* <li>By default is not set.</li>
* </ul>
* This value takes precedence over the
* <a href="https://maven.apache.org/pom.html#Prerequisites">POM's Maven prerequisite</a> in Maven 4.
*
* @since 3.8.0
*/
@Parameter(defaultValue = VALUE_AUTO)
@Parameter
String requiredMavenVersion;

/**
Expand Down
2 changes: 2 additions & 0 deletions maven-plugin-report-plugin/src/it/plugin-report-annotations/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@ under the License.
<configuration>
<skipErrorNoDescriptorsFound>true</skipErrorNoDescriptorsFound>
<goalPrefix>prefix</goalPrefix>
<requiredJavaVersion>auto</requiredJavaVersion>
<requiredMavenVersion>auto</requiredMavenVersion>
</configuration>
<executions>
<execution>
Expand Down
2 changes: 2 additions & 0 deletions maven-plugin-report-plugin/src/it/plugin-report/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ under the License.
<version>@project.version@</version>
<configuration>
<goalPrefix>prefix</goalPrefix>
<requiredJavaVersion>auto</requiredJavaVersion>
<requiredMavenVersion>auto</requiredMavenVersion>
</configuration>
</plugin>
<plugin>
Expand Down