Skip to content

Bump org.jsoup:jsoup from 1.18.1 to 1.21.2 #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −6
Open

Bump org.jsoup:jsoup from 1.18.1 to 1.21.2 #951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a9956a
Bump org.jsoup:jsoup from 1.18.1 to 1.21.2
dependabot[bot] Aug 26, 2025
3fce183
fix tests
slawekjaranowski Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion maven-plugin-plugin/src/it/help-basic-deprecated-annotation-only/expected-help.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ help-deprecated-annotation-only:test

MOJO-DESCRIPTION. Some "quotation" marks and backslashes '\\', some important
javadoc
and an inline link to test.AnotherMojo.
and an inline link to test.AnotherMojo .

Available parameters:

Expand Down
2 changes: 1 addition & 1 deletion maven-plugin-plugin/src/it/help-basic-jdk11/expected-help.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ help-jdk11:test

MOJO-DESCRIPTION. Some "quotation" marks and backslashes '\\', some important
javadoc
and an inline link to test.AnotherMojo.
and an inline link to test.AnotherMojo .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additional space looks wrong.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but makes that the test pass

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, that points at a regression in jsoup as that conversion is done by it.


Available parameters:

Expand Down
2 changes: 1 addition & 1 deletion maven-plugin-plugin/src/it/help-basic/expected-help.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ help:test

MOJO-DESCRIPTION. Some "quotation" marks and backslashes '\\', some important
javadoc
and an inline link to test.AnotherMojo.
and an inline link to test.AnotherMojo .

Available parameters:

Expand Down
4 changes: 2 additions & 2 deletions ...en/tools/plugin/extractor/annotations/converter/JavadocBlockTagsToXhtmlConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class JavadocBlockTagsToXhtmlConverterTest {
@Test
void testSee() {
assertEquals(
"<br /><strong>See also:</strong> \"Some reference\"",
"<br />\n<strong>See also:</strong> \"Some reference\"",
converter.convert("see", "\"Some reference\"", context));
assertEquals(
", <a href=\"example.com\">Example</a>",
Expand All @@ -57,7 +57,7 @@ void testSee() {
ConverterContext context2 =
new SimpleConverterContext("my.package", URI.create("https://javadoc.example.com/"));
assertEquals(
"<br /><strong>See also:</strong> <a href=\"example.com\">Example</a>",
"<br />\n<strong>See also:</strong> <a href=\"example.com\">Example</a>",
converter.convert("see", "<a href=\"example.com\">Example</a>", context2));
}

Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@
<dependency>
<groupId>org.jsoup</groupId>
<artifactId>jsoup</artifactId>
<version>1.18.1</version>
<version>1.21.2</version>
</dependency>
<dependency>
<groupId>org.ow2.asm</groupId>
Expand Down