Document deprecation of ModelETL#getModel()#1447
Merged
elharo merged 1 commit intoapache:masterfrom Jan 14, 2026
Merged
Conversation
elharo
reviewed
Jan 5, 2026
| * {@link #transform()} processing phase is fully implemented | ||
| * and callers no longer need to access the intermediate model | ||
| * directly. | ||
| * |
Contributor
Author
There was a problem hiding this comment.
delete blank line
Thanks for the review. I’ve removed the blank line as requested.
c828b26 to
bb9e204
Compare
Clarified that getModel() is a temporary legacy accessor and will be removed once transform() is fully implemented. Added guidance to rely on the extract -> transform -> load pipeline instead.
bb9e204 to
2bf5dba
Compare
elharo
approved these changes
Jan 8, 2026
|
@elharo Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarified that getModel() is a temporary legacy accessor and will be removed once transform() is fully implemented. Added guidance to rely on the extract -> transform -> load pipeline instead.
This work is part of Issue #1436 – Document Deprecations and improves the deprecation documentation for ModelETL#getModel().
mvn clean installReference: #1436
/cc @elharo
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.