-
Notifications
You must be signed in to change notification settings - Fork 145
Document deprecations in PrepareReleaseMojo and PerformReleaseMojo #1448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Document deprecations in PrepareReleaseMojo and PerformReleaseMojo #1448
Conversation
Clarified that getModel() is a temporary legacy accessor and will be removed once transform() is fully implemented. Added guidance to rely on the extract -> transform -> load pipeline instead.
| * true, which activates the profile "<code>release-profile</code>" as inherited from | ||
| * <a href="/ref/3.8.5/maven-model-builder/super-pom.html">the super pom</a>. | ||
| * Whether to use the default {@code release-profile} from the Maven | ||
| * super POM (Maven 2 and 3), which adds sources and javadocs to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete (Maven 2 and 3),
| * Controls whether the plugin should generate release POMs during the | ||
| * prepare phase. | ||
| * | ||
| * @deprecated This flag is no longer the preferred way to perform a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete "This flag is no longer the preferred way to perform a release."
| * prepare phase. | ||
| * | ||
| * @deprecated This flag is no longer the preferred way to perform a | ||
| * release. Use the dedicated {@code release:prepare-with-pom} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just "Use the {@code release:prepare-with-pom} goal instead."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review. I’ve updated the Javadoc as requested.
Improved documentation for deprecated parameters: - generateReleasePoms: explained deprecation and pointed users to release:prepare-with-pom. - useReleaseProfile: clarified that the super POM release-profile is being removed and projects should rely on explicit profiles instead. No functional changes. Build verified.
56e7efd to
28abf56
Compare
This PR is part of Issue #1436 – Document Deprecations and improves the
documentation of deprecated parameters in the Maven Release Plugin.
to explain why it is deprecated and recommend using
release:prepare-with-pom instead.
to clarify that the Maven super POM release-profile is being removed
and projects should rely on explicit project-defined release profiles.
mvn clean install.Reference: #1436
/cc @elharo
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.