Remove plexus components.xml

[elharo]

This file appears to no longer be needed as all integration tests pass when it's removed. It also seems to be quite out of date in terms of versions. If removing this does break something, then there's a missing test somewhere,

[cstamas]

I hope this is a joke...

[elharo]

If you think we need to keep these bindings, there are two questions that need to be answered:

1. What test is missing? There are lot of integration tests in this project and they all pass.
2. How does one set up a binding module for Guice directly without going through the plexus adapter?

https://cwiki.apache.org/confluence/display/MAVEN/Maven+Ecosystem+Cleanup

[cstamas]

We need to decide how to do this first... please see https://issues.apache.org/jira/browse/MNG-8472 for context (esp mentioned issues and list discussion).

[elharo]

I made some updates to the Wiki. Seems it is asking folks to do things that can't yet be done.

[elharo]

Question for @cstamas what observable effect do you expect from merging this PR? As far as I can tell the only change is that the jar file is a little smaller. Behavior is the same. If there is a desired observable effect, we can write a test for it.

[cstamas]

@elharo one obvious one: use this plugin in a project used in "ordinary" way (not as extension) and observe plugin versions used in the build, they come from Maven core (with Maven 3.9.9 you should see these versions: https://github.com/apache/maven/blob/dcf3d70c2614ceca6953f98843d2ad3f053f5341/maven-core/src/main/resources/META-INF/plexus/default-bindings.xml#L195-L234). Then, in same project, make maven-war-plugin and extension=true, and then you will see these plugin versions used instead:

maven-war-plugin/src/main/resources-filtered/META-INF/plexus/components.xml

Lines 44 to 86 in 6943938

	<!--
	| WAR
	|-->
	<component>
	<role>org.apache.maven.lifecycle.mapping.LifecycleMapping</role>
	<role-hint>war</role-hint>
	<implementation>org.apache.maven.lifecycle.mapping.DefaultLifecycleMapping</implementation>
	<configuration>
	<lifecycles>
	<lifecycle>
	<id>default</id>
	<!-- START SNIPPET: war-lifecycle -->
	<phases>
	<process-resources>
	org.apache.maven.plugins:maven-resources-plugin:3.3.1:resources
	</process-resources>
	<compile>
	org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile
	</compile>
	<process-test-resources>
	org.apache.maven.plugins:maven-resources-plugin:3.3.1:testResources
	</process-test-resources>
	<test-compile>
	org.apache.maven.plugins:maven-compiler-plugin:3.11.0:testCompile
	</test-compile>
	<test>
	org.apache.maven.plugins:maven-surefire-plugin:3.1.2:test
	</test>
	<package>
	org.apache.maven.plugins:maven-war-plugin:${project.version}:war
	</package>
	<install>
	org.apache.maven.plugins:maven-install-plugin:3.1.1:install
	</install>
	<deploy>
	org.apache.maven.plugins:maven-deploy-plugin:3.1.1:deploy
	</deploy>
	</phases>
	<!-- END SNIPPET: war-lifecycle -->
	</lifecycle>
	</lifecycles>
	</configuration>
	</component>

[cstamas]

I made some updates to the Wiki. Seems it is asking folks to do things that can't yet be done.

And this is wrong: this is NOT about dropping Plexus XML (it is doable), it is about dropping lifecycle component (that can be defined as plexus xml but also as a jsr330 component as well). Lifecycle can be defined in multiple ways, as explained here https://cstamas.org/blog/2024/09/add-new-maven-lifecycle/

[github-actions]

This pull request is stale because it has been waiting for feedback for 60 days. Remove the stale label or comment on this PR, or it will be automatically closed in 30 days.

[elharo]

Leaving open for useful context