add test assertion to resolve @SuppressWarnings("checkstyle:UnusedLocalVariable")
#2365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pankraz76
changed the title
@SuppressWarnings("checkstyle:UnusedLocalVariable")
Pankraz76
force-pushed
the
error-prone-pmd-ArtifactHandlerTest
branch
2 times, most recently
from
51f7046 to
f541e7e
Compare
Pankraz76
commented
May 21, 2025
| if (line.startsWith("||")) { | ||
| String[] cols = line.split("\\|\\|"); | ||
| String[] expected = new String[] { | ||
| "", |
Pankraz76
commented
May 21, 2025
| "language", | ||
| "added to classpath", | ||
| "includesDependencies", | ||
| "" |
Contributor
Author
There was a problem hiding this comment.
this is not required. "foo", works as well.
Pankraz76
force-pushed
the
error-prone-pmd-ArtifactHandlerTest
branch
from
f541e7e to
adb73ac
Compare
Pankraz76
commented
May 21, 2025
| // Packaging/Directory is Maven1 remnant!!! | ||
| // assertEquals(handler.getPackaging(), packaging, type + " packaging"); | ||
| assertThat(handler.getPackaging()).isNotEmpty(); | ||
| assertThat(VALID_PACKAGING_TYPES).contains(packaging); |
Contributor
Author
There was a problem hiding this comment.
resolve UnusedLocalVariable
Pankraz76
force-pushed
the
error-prone-pmd-ArtifactHandlerTest
branch
from
adb73ac to
9f1e7cf
Compare
Pankraz76
force-pushed
the
error-prone-pmd-ArtifactHandlerTest
branch
from
9f1e7cf to
1fb36a4
Compare
This was referenced May 21, 2025
Closed
Merged
Contributor
Author
|
whats the issue here? is testing not valued? |
Contributor
Author
|
its the same topic like done in: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add test assertion to resolve
@SuppressWarnings("checkstyle:UnusedLocalVariable")ref: