Skip to content

chore: DefaultArtifactDeployer PMD-Rule: EmptyControlStatement #2371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore: DefaultArtifactDeployer PMD-Rule: EmptyControlStatement #2371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions ...aven-compat/src/main/java/org/apache/maven/artifact/deployer/DefaultArtifactDeployer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,7 @@
import org.apache.maven.artifact.repository.ArtifactRepository;
import org.apache.maven.artifact.repository.DefaultArtifactRepository;
import org.apache.maven.artifact.repository.LegacyLocalRepositoryManager;
import org.apache.maven.artifact.repository.metadata.ArtifactRepositoryMetadata;
import org.apache.maven.artifact.repository.metadata.MetadataBridge;
import org.apache.maven.artifact.repository.metadata.SnapshotArtifactRepositoryMetadata;
import org.apache.maven.plugin.LegacySupport;
import org.apache.maven.project.artifact.ProjectArtifactMetadata;
import org.codehaus.plexus.logging.AbstractLogEnabled;
Expand Down Expand Up @@ -106,9 +104,6 @@ public void deploy(
org.eclipse.aether.artifact.Artifact pomArtifact = new SubArtifact(mainArtifact, "", "pom");
pomArtifact = pomArtifact.setFile(projectArtifactMetadata.getFile());
request.addArtifact(pomArtifact);
} else if (metadata instanceof SnapshotArtifactRepositoryMetadata
|| metadata instanceof ArtifactRepositoryMetadata) {
// eaten, handled by repo system
Copy link
Contributor Author

@Pankraz76 Pankraz76 May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should I preserve this information? Empty business logic as documentation feels overkill.

} else {
request.addMetadata(new MetadataBridge(metadata));
}
Expand Down
3 changes: 0 additions & 3 deletions ...en-compat/src/main/java/org/apache/maven/artifact/installer/DefaultArtifactInstaller.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,6 @@ public void install(File source, Artifact artifact, ArtifactRepository localRepo
org.eclipse.aether.artifact.Artifact pomArtifact = new SubArtifact(mainArtifact, "", "pom");
pomArtifact = pomArtifact.setFile(projectArtifactMetadata.getFile());
request.addArtifact(pomArtifact);
} else if (metadata instanceof SnapshotArtifactRepositoryMetadata
|| metadata instanceof ArtifactRepositoryMetadata) {
// eaten, handled by repo system
} else {
request.addMetadata(new MetadataBridge(metadata));
}
Expand Down