mcu/nrf5340: Disable UART before pin configuration #3561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code was modifying UART PSEL configuration even when peripheal was alreay enabled. In normal case this is not a problem since during hal_uart_init is called peripheral is not enabled. However when booloader already enabled UART and application tried to used peripheral with different pin configuration change would not be apply With this change peripheral is disabled before modification it will be enabled later when needed. Signed-off-by: Jerzy Kasenberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code was modifying UART PSEL configuration even
when peripheal was alreay enabled.
In normal case this is not a problem since during
hal_uart_init is called peripheral is not enabled. However when booloader already enabled UART and
application tried to used peripheral with different pin configuration change would not be apply
With this change peripheral is disabled before
modification it will be enabled later when needed.