Improve newt upgrade #574
Merged
Improve newt upgrade #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to use pattern matching on allowed/ignored repo lists instead of simple string comparison only. By default, string comparison is used. If pattern begins with "~", it's compiled as a regexp (excluding "~" character). The regexp pattern has added start of string anchor automatically, i.e. pattern "~apache.*" is compiled as "^apache.*". If pattern ends with "*", it's used as a wildcard and matches any repo starting with pattern excluding "*" character, i.e. pattern "apache-*" is equivalent to regexp "^apache-.*$".
sjanc
approved these changes
Oct 25, 2024
kasjer
approved these changes
Oct 25, 2024
Contributor
kasjer
left a comment
kasjer
left a comment
There was a problem hiding this comment.
Tested OK, code not inspected.
m-gorecki
approved these changes
Oct 25, 2024
This improves newt upgrade by optimizing the way repos are checked for potential upgrade. Each repo is now checked only once i.e. if it was loaded from project.yml and updated it's not considered for update anymore. This also means no duplicate messages are printed.
This improves newt upgrade output to include message when it's fetching updates to each repository and also skips "trying to make changes..." message if there's no prompt requested.
If external repo has version specified as commit SHA and that SHA is currently checked out, we don't need to fetch that repo.
andrzej-kaczmarek
force-pushed
the
upgrade-optimize
branch
from
3322377 to
10f0063
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.