Add support for SmPL overlay patches #577
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for SmPL cocci patches.
sjanc
reviewed
Oct 28, 2024
Contributor
sjanc
left a comment
sjanc
left a comment
There was a problem hiding this comment.
I think this should be optional dependency, if coccinelle newt should just print warning and skip patch
Contributor
This will make package likely unusable so it kind of defeats the purpose of patches. Another issue is that spatch will leave working tree in dirty state so subsequent updates will fail. |
Contributor
|
Perhaps a more portable option would be to have .cocci in separate directory so they can be used to generate .patch manually in case library is updated. In such case .patch will be applied by newt. |
Contributor
|
another problem is that coccinnelle is not available on windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for SmPL cocci patches.