nimble/ll: Various fixes found during LL prequalification #1970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzej-kaczmarek
force-pushed
the
ll-quali-fixes
branch
from
dc497d9 to
407f256
Compare
This adds validation of phy parameter in HCI LE BIG Create to make sure we don't accept phy that we do not support.
Add HCI commands related to ISO Data Path to commands bitmask - we already support them.
phy parameter in PAST HCI command shall have only single bit set.
This adds validation of max_transport_latency parameter for HCI LE BIG Create command. The calculations are done as per Core 6.0, Vol 6, Part G, 3.2.1 and 3.2.2.
Trying to create BIG with the same handle as existing one should return command disallowed status.
If peripheral role is disabled, we still need to handle LL_PAUSE_ENC_RSP whic is used for encryption key refresh procedure.
We need to make sure that counters and event start time are updated atomically so they are in sync when BIGInfo is calculated.
andrzej-kaczmarek
force-pushed
the
ll-quali-fixes
branch
from
407f256 to
532590a
Compare
sjanc
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.