Skip to content

Conversation

@lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Jan 8, 2026

A follow-up to:
#9042

fixing two Fixes in enterprise/web.jsf to not keep javac-related instances across javac contexts. I tried to minimize the disruption in the code, although I suspect that merging these two hints into one would be possible.


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

@lahodaj lahodaj added this to the NB30 milestone Jan 8, 2026
@lahodaj lahodaj added the enterprise [ci] enable enterprise job label Jan 8, 2026
@lahodaj lahodaj marked this pull request as ready for review January 8, 2026 14:42
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@mbien mbien added the hints label Jan 8, 2026
@mbien
Copy link
Member

mbien commented Jan 8, 2026

milestone was set to NB 30, will change it to NB 29 because it is still pre-freeze and this bigfix is fairly isolated/low risk IMO.

@mbien mbien modified the milestones: NB30, NB29 Jan 8, 2026
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a minimal JSF project and the hint is correctly generated for a ManagedBean and its scoping annotation javax.faces.bean.RequestScoped. Also correctly the hint is not generated for Named bean with javax.enterprise.context.RequestScoped scope.

The implementation looks sane to me. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enterprise [ci] enable enterprise job hints

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants