Skip to content

Conversation

@haidubogdan
Copy link
Contributor

@haidubogdan haidubogdan commented Jan 14, 2026

Fixes parser error display for :host and :slotted pseudo-elements.
The solution is a bit of compromise and necessity as these pseudo elements use a simple compound selector compared to :where, :is, :has and the host pseudo class can work without a selector and I needed to avoid the one rule node fail in antrl3.
The Css3.g antlr 3 rules would benefit from a simplification in the future :) .

Before:
image

After
image


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

@mbien mbien added CSS [ci] enable web job ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Jan 14, 2026
@apache apache locked and limited conversation to collaborators Jan 14, 2026
@apache apache unlocked this conversation Jan 14, 2026
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks sane to me. Thank you.

@matthiasblaesing matthiasblaesing merged commit 0983c5e into apache:master Jan 15, 2026
117 of 120 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) CSS [ci] enable web job

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants