-
Notifications
You must be signed in to change notification settings - Fork 99
MINIFICPP-2596 Add XMLRecordSetWriter controller service #1997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
83bec13 to
fd19916
Compare
ff5b603 to
61a9e16
Compare
fd19916 to
27903b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a new XMLRecordSetWriter controller service for Apache NiFi MiNiFi C++, which converts RecordSet data structures to XML format. The writer provides configurable XML output options including root/record tag naming, array element wrapping, XML declaration control, and pretty printing.
Key changes include:
- Implementation of XMLRecordSetWriter controller service with comprehensive property configuration
- Unit test suite covering various XML output scenarios and edge cases
- Documentation updates to include the new controller service
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| XMLRecordSetWriter.h | Header file defining the XMLRecordSetWriter class with properties and enum for array wrapping options |
| XMLRecordSetWriter.cpp | Implementation of XML conversion logic and property validation |
| XMLRecordSetWriterTests.cpp | Comprehensive unit tests covering functionality and error conditions |
| CONTROLLERS.md | Documentation addition for the new XMLRecordSetWriter controller service |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
extensions/standard-processors/controllers/XMLRecordSetWriter.h
Outdated
Show resolved
Hide resolved
extensions/standard-processors/controllers/XMLRecordSetWriter.cpp
Outdated
Show resolved
Hide resolved
61a9e16 to
579fd16
Compare
b7b0564 to
2d9cdcd
Compare
78f16c6 to
12d65b4
Compare
2d9cdcd to
e230c2c
Compare
12d65b4 to
373020b
Compare
10072a2 to
d070bdc
Compare
extensions/standard-processors/controllers/XMLRecordSetWriter.cpp
Outdated
Show resolved
Hide resolved
extensions/standard-processors/controllers/XMLRecordSetWriter.cpp
Outdated
Show resolved
Hide resolved
extensions/standard-processors/controllers/XMLRecordSetWriter.cpp
Outdated
Show resolved
Hide resolved
9e2686c to
888ef22
Compare
d070bdc to
a03562c
Compare
https://issues.apache.org/jira/browse/MINIFICPP-2596
Depends on #1995
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.