Skip to content

Conversation

@lordgamez
Copy link
Contributor

https://issues.apache.org/jira/browse/MINIFICPP-2596

Depends on #1995


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@lordgamez lordgamez force-pushed the MINIFICPP-2596 branch 2 times, most recently from 83bec13 to fd19916 Compare August 4, 2025 12:29
@lordgamez lordgamez marked this pull request as ready for review August 5, 2025 09:28
@lordgamez lordgamez requested a review from Copilot August 14, 2025 11:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a new XMLRecordSetWriter controller service for Apache NiFi MiNiFi C++, which converts RecordSet data structures to XML format. The writer provides configurable XML output options including root/record tag naming, array element wrapping, XML declaration control, and pretty printing.

Key changes include:

  • Implementation of XMLRecordSetWriter controller service with comprehensive property configuration
  • Unit test suite covering various XML output scenarios and edge cases
  • Documentation updates to include the new controller service

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
XMLRecordSetWriter.h Header file defining the XMLRecordSetWriter class with properties and enum for array wrapping options
XMLRecordSetWriter.cpp Implementation of XML conversion logic and property validation
XMLRecordSetWriterTests.cpp Comprehensive unit tests covering functionality and error conditions
CONTROLLERS.md Documentation addition for the new XMLRecordSetWriter controller service

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@lordgamez lordgamez force-pushed the MINIFICPP-2596 branch 2 times, most recently from b7b0564 to 2d9cdcd Compare August 26, 2025 09:04
@lordgamez lordgamez force-pushed the MINIFICPP-2596 branch 2 times, most recently from 10072a2 to d070bdc Compare September 8, 2025 08:38
@fgerlits fgerlits closed this in 8f83e3d Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants