Skip to content

Conversation

@lordgamez
Copy link
Contributor

https://issues.apache.org/jira/browse/MINIFICPP-2679

Depends on github.com//pull/2075


Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@lordgamez lordgamez added depends-on-another-PR low-impact Test only or trivial change that's most likely not gonna introduce any new bugs labels Nov 26, 2025
@lordgamez lordgamez force-pushed the MINIFICPP-2679 branch 2 times, most recently from 4f0e4cb to c10e4a5 Compare November 27, 2025 10:20
@lordgamez lordgamez marked this pull request as ready for review November 27, 2025 11:19
Comment on lines +63 to +65
if minifi_container_name == "nifi":
context.containers["nifi"].flow_definition.add_processor(processor)
return
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way of deciding what to do raises a red flag for me, but I'll leave it up to @martinzink to say if this design fits in the framework or not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the first design of the new framework the flow building steps assumed that the steps are only meant for minifi and that there is only 1 minifi container in the test scenario. Later this was changed to be able to have multiple minifi containers in a test scenario and for that containers are identified and stored by their names. As we only have a single NiFi container in all of our tests involving NiFi it seemed to be the easiest approach to check the container name in case we want to add a flow step to the container. I also see that this may be a bit iffy in case we want to use multiple NiFi containers in a scenario in the future, but I could not find a better yet clean solution for this, so it can be up for discussion and I'm open for new ideas.

fgerlits

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

depends-on-another-PR low-impact Test only or trivial change that's most likely not gonna introduce any new bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants