-
Notifications
You must be signed in to change notification settings - Fork 99
MINIFICPP-2679 Move HTTP tests to modular docker tests #2077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: MINIFICPP-2682
Are you sure you want to change the base?
Conversation
4f0e4cb to
c10e4a5
Compare
behave_framework/src/minifi_test_framework/containers/container.py
Outdated
Show resolved
Hide resolved
behave_framework/src/minifi_test_framework/containers/nifi_container.py
Outdated
Show resolved
Hide resolved
| if minifi_container_name == "nifi": | ||
| context.containers["nifi"].flow_definition.add_processor(processor) | ||
| return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way of deciding what to do raises a red flag for me, but I'll leave it up to @martinzink to say if this design fits in the framework or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the first design of the new framework the flow building steps assumed that the steps are only meant for minifi and that there is only 1 minifi container in the test scenario. Later this was changed to be able to have multiple minifi containers in a test scenario and for that containers are identified and stored by their names. As we only have a single NiFi container in all of our tests involving NiFi it seemed to be the easiest approach to check the container name in case we want to add a flow step to the container. I also see that this may be a bit iffy in case we want to use multiple NiFi containers in a scenario in the future, but I could not find a better yet clean solution for this, so it can be up for discussion and I'm open for new ideas.
0306957 to
eaa861d
Compare
c10e4a5 to
4681e3c
Compare
https://issues.apache.org/jira/browse/MINIFICPP-2679
Depends on github.com//pull/2075
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.