Skip to content

Conversation

@exceptionfactory
Copy link
Contributor

Summary

NIFI-14934 Switches the parent NAR for the GitHub bundle from nifi-standard-shared-nar to nifi-standard-services-api-nar to support overriding the version of Jackson to 2.19.0.

GitHub client version 1.329 is not compatible with Jackson 2.20.0 due to the use of a removed static reference for com.fasterxml.jackson.databind.PropertyNamingStrategy.

The current set of changes provide a maintainable workaround pending the release of a new GitHub client library version compatible with Jackson 2.20.0.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

- Changing from shared-nar to standard-services-api-nar enables using Jackson 2.19.0 as required for current versions of the GitHub client library
Copy link
Contributor

@pvillard31 pvillard31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @exceptionfactory - I confirmed this solves the problem. Hopefully we have a new release of the client soon that includes the fix. For reference: hub4j/github-api#2138

@pvillard31 pvillard31 closed this in 9bc7e40 Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants