Skip to content

NIFI-15669: Refactored ConsumeKinesis to remove dependency on KCL. Th…#10964

Open
markap14 wants to merge 1 commit intoapache:mainfrom
markap14:NIFI-15669
Open

NIFI-15669: Refactored ConsumeKinesis to remove dependency on KCL. Th…#10964
markap14 wants to merge 1 commit intoapache:mainfrom
markap14:NIFI-15669

Conversation

@markap14
Copy link
Contributor

@markap14 markap14 commented Mar 4, 2026

…is provides much faster startup times and drastically reduces heap utilization when using Enhanced Fan Out (EFO) mode.

Summary

NIFI-00000

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
  • Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@exceptionfactory exceptionfactory self-assigned this Mar 4, 2026
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extensive work on redesigning this Processor @markap14!

I plan to do a more thorough review, for now, highlighting an integration test failure that may point to some unstable expectations.

Error:  Tests run: 18, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 130.6 s <<< FAILURE! -- in org.apache.nifi.processors.aws.kinesis.ConsumeKinesisIT
Error:  org.apache.nifi.processors.aws.kinesis.ConsumeKinesisIT.testKplMultipleAggregatedRecords -- Time elapsed: 4.039 s <<< FAILURE!
org.opentest4j.AssertionFailedError: 3 aggregated records x 5 sub-records each ==> expected: <15> but was: <0>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:158)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:139)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:201)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:152)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:590)
	at org.apache.nifi.processors.aws.kinesis.ConsumeKinesisIT.testKplMultipleAggregatedRecords(ConsumeKinesisIT.java:618)

@markap14 markap14 force-pushed the NIFI-15669 branch 2 times, most recently from b81b9ea to 62fb403 Compare March 5, 2026 16:52
…is provides much faster startup times and drastically reduces heap utilization when using Enhanced Fan-Out (EFO) mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants