exclude cxx-oot-build test #3186
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trns1997
force-pushed
the
use-updated-nuttx-add-subdir
branch
from
ad972b0 to
7424426
Compare
|
ping @raiden00pl |
xiaoxiang781216
approved these changes
Sep 28, 2025
cederom
requested changes
Sep 28, 2025
There was a problem hiding this comment.
build errors needs fix :-(
CMake Error at /github/workspace/sources/apps/testing/cxx-oot-build/CMakeLists.txt:40 (add_executable):
Cannot find source file:
/github/workspace/sources/nuttx/src/HelloWorld.cpp
CMake Error at /github/workspace/sources/apps/testing/cxx-oot-build/CMakeLists.txt:40 (add_executable):
No SOURCES given to target: oot
CMake Generate step failed. Build files cannot be regenerated correctly.
Building NuttX...
ninja: error: loading 'build.ninja': No such file or directory
ninja: error: loading 'build.ninja': No such file or directory
cp: cannot stat 'nuttx': No such file or directory
cp: cannot stat 'nuttx': No such file or directory
ninja: error: loading 'build.ninja': No such file or directory
ninja: error: loading 'build.ninja': No such file or directory
apache/nuttx#17105 Need this to be merged for this to work. Sorry i created the PR a bit too quickly :\ |
raiden00pl
approved these changes
Sep 29, 2025
Remove the previous guard logic and use a proper CMake `exclude` rule to prevent `cxx-oot-build` from being included when building projects with CMake. * Ensures OOT test project is not pulled into normal apps. * Keeps CI and export tests isolated from regular builds. Signed-off-by: trns1997 <[email protected]>
trns1997
force-pushed
the
use-updated-nuttx-add-subdir
branch
from
7424426 to
df9748c
Compare
|
ping @cederom @xiaoxiang781216 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please adhere to Contributing Guidelines.
Summary
This PR updates the NuttX apps CMake configuration to exclude the cxx-oot-build directory from the build process.
Previously, cxx-oot-build was guarded manually to avoid being included during builds. With the new EXCLUDE support added to nuttx_add_subdirectory() (see apache/nuttx#17105) this PR replaces that guard logic with the cleaner exclusion rule.
This ensures that cxx-oot-build is consistently ignored during app builds, while simplifying the CMake configuration.
Impact
Build system: cxx-oot-build is now excluded using the standardized EXCLUDE mechanism. Removes custom guard logic, reducing complexity.
Compatibility: No impact on users who do not use out-of-tree builds. Transparent to standard builds.
Testing