refactor and modify the bugs of examples/elf project #3224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rearrange the elf test directory, make the sub-testcase in separate directory Signed-off-by: anjiahao <[email protected]>
delete the mod_symtab.c generate procedure Signed-off-by: anjiahao <[email protected]>
make the example elf can work with SIGNAL disabled Signed-off-by: v-tangmeng <[email protected]>
xiaoxiang781216
previously approved these changes
Nov 28, 2025
if defined CONFIG_EXAMPLES_ELF and CONFIG_EXAMPLES_MODLUE, elf will generated BINDIR, so generated symtab will interference. It supports inputting multiple specified files in mksymtab.sh to avoid interference. Signed-off-by: anjiahao <[email protected]>
extinguish
force-pushed
the
apps_examples_elf_refactor
branch
from
19b642d to
44023f0
Compare
cederom
requested changes
Nov 28, 2025
Contributor
cederom
left a comment
cederom
left a comment
There was a problem hiding this comment.
Thank you @extinguish, CI build errors, please fix :-)
====================================================================================
Configuration/Tool: nucleo-h743zi/elf,CONFIG_ARM_TOOLCHAIN_CLANG
2025-11-28 10:31:47
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
Enabling CONFIG_ARM_TOOLCHAIN_CLANG
Building NuttX...
Error: <inline asm>:5:12: error: Could not find incbin file '../../apps/examples/elf/tests/romfs.img'
5 | .incbin "../../apps/examples/elf/tests/romfs.img"
| ^
1 error generated.
make[2]: *** [/github/workspace/sources/nuttx/boards/Board.mk:83: stm32_romfs_initialize.o] Error 1
make[2]: Target 'libboard.a' not remade because of errors.
make[1]: *** [Makefile:187: board/libboard.a] Error 2
make[1]: Target 'nuttx' not remade because of errors.
make: *** [tools/Unix.mk:552: nuttx] Error 2
make: Target 'all' not remade because of errors.
/github/workspace/sources/nuttx/tools/testbuild.sh: line 385: /github/workspace/sources/nuttx/../nuttx/nuttx.manifest: No such file or directory
[1/1] Normalize nucleo-h743zi/elf
On branch master
Your branch is up to date with 'origin/master'.
linguini1
requested changes
Nov 29, 2025
Contributor
linguini1
left a comment
linguini1
left a comment
There was a problem hiding this comment.
The testing section is insufficient.
has passed the relative tests
What are these tests and what were the results? With logs please.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
this request is depends on apache/nuttx#17397
Impact
mainly affect the examples/elf project, has no impact on other modules
Testing
has passed the relative tests