-
Notifications
You must be signed in to change notification settings - Fork 674
system/i3c: added i3c tools #3290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Donny9
wants to merge
1
commit into
apache:master
Choose a base branch
from
Donny9:i3c
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # ############################################################################## | ||
| # apps/system/i3c/CMakeLists.txt | ||
| # | ||
| # Licensed to the Apache Software Foundation (ASF) under one or more contributor | ||
| # license agreements. See the NOTICE file distributed with this work for | ||
| # additional information regarding copyright ownership. The ASF licenses this | ||
| # file to you under the Apache License, Version 2.0 (the "License"); you may not | ||
| # use this file except in compliance with the License. You may obtain a copy of | ||
| # the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| # License for the specific language governing permissions and limitations under | ||
| # the License. | ||
| # | ||
| # ############################################################################## | ||
|
|
||
| if(CONFIG_SYSTEM_I3CTOOL) | ||
| set(SRCS i3c_main.c) | ||
| nuttx_add_application(NAME i3c SRCS ${SRCS} STACKSIZE | ||
| ${CONFIG_DEFAULT_TASK_STACKSIZE}) | ||
| endif() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # | ||
| # For a description of the syntax of this configuration file, | ||
| # see the file kconfig-language.txt in the NuttX tools repository. | ||
| # | ||
|
|
||
| menuconfig SYSTEM_I3CTOOL | ||
| tristate "I3C tool" | ||
| default n | ||
| depends on I3C | ||
| select I3C_DRIVER | ||
| ---help--- | ||
| Enable support for the I3C tool. | ||
|
|
||
| if SYSTEM_I3CTOOL | ||
|
|
||
| config I3CTOOL_DEF_TARGETADDR | ||
| hex "Default I3C device target address" | ||
| default 0xffff | ||
| ---help--- | ||
| Default I3C device target address (default: 0xffff) | ||
|
|
||
| config I3CTOOL_DEFBUS | ||
| int "Default I2C bus number" | ||
| default 0 | ||
| ---help--- | ||
| Default I3C bus number (default: 0) | ||
|
|
||
| endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| ############################################################################ | ||
| # apps/system/i3c/Make.defs | ||
| # | ||
| # Licensed to the Apache Software Foundation (ASF) under one or more | ||
| # contributor license agreements. See the NOTICE file distributed with | ||
| # this work for additional information regarding copyright ownership. The | ||
| # ASF licenses this file to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance with the | ||
| # License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| # License for the specific language governing permissions and limitations | ||
| # under the License. | ||
| # | ||
| ############################################################################ | ||
|
|
||
| ifneq ($(CONFIG_SYSTEM_I3CTOOL),) | ||
| CONFIGURED_APPS += $(APPDIR)/system/i3c | ||
| endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| ############################################################################ | ||
| # apps/system/i3c/Makefile | ||
| # | ||
| # Licensed to the Apache Software Foundation (ASF) under one or more | ||
| # contributor license agreements. See the NOTICE file distributed with | ||
| # this work for additional information regarding copyright ownership. The | ||
| # ASF licenses this file to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance with the | ||
| # License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| # License for the specific language governing permissions and limitations | ||
| # under the License. | ||
| # | ||
| ############################################################################ | ||
|
|
||
| include $(APPDIR)/Make.defs | ||
|
|
||
| MAINSRC = i3c_main.c | ||
|
|
||
| PROGNAME = i3c | ||
| PRIORITY = SCHED_PRIORITY_DEFAULT | ||
| STACKSIZE = $(CONFIG_DEFAULT_TASK_STACKSIZE) | ||
| MODULE = $(CONFIG_SYSTEM_I3CTOOL) | ||
|
|
||
| include $(APPDIR)/Application.mk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| # System / `i3c` I3C Tool | ||
|
|
||
| The I3C tool provides a way to debug I3C related problems. This README file will | ||
| provide usage information for the I3C tools. | ||
|
|
||
| - System Requirements | ||
| - I3C Driver | ||
| - I2C Driver, If Has I2C Device | ||
| - Configuration Options | ||
|
|
||
| # Configuration Options | ||
|
|
||
| - `CONFIG_NSH_BUILTIN_APPS` – Build the tools as an NSH built-in command. | ||
| - `CONFIG_I3CTOOL_DEFBUS` – A default bus number (default `0`). | ||
|
|
||
| # Usage: | ||
|
|
||
| Write one data byte in single private transfer | ||
|
|
||
| i3c -b bus -m manufid -p partid -w 0xde | ||
|
|
||
| Write multiple data bytes in single private transfer | ||
|
|
||
| i3c -b bus -m manufid -p partid -w "0xde,0xad,0xbe,0xef" | ||
|
|
||
| Write multiple data bytes in multiple private transfers | ||
|
|
||
| i3c -b bus -m manufid -p partid -w "0xde,0xad" -w "0xbe,0xef" | ||
|
|
||
| Read multiple data bytes in single private transfer | ||
|
|
||
| i3c -b bus -m manufid -p partid -r <data_length> | ||
|
|
||
| Read multiple data bytes in multiple private transfer | ||
|
|
||
| i3c -b bus -m manufid -p partid -r <data_length> -r <data_length> | ||
|
|
||
| Read and write multiple data bytes in multiple private transfer | ||
|
|
||
| i3c -b bus -m manufid -p partid -w "0xde,0xad,0xbe,0xef" -r <data_length> | ||
|
|
||
| Get device information using PID | ||
|
|
||
| i3c -b bus -m manufid -p partid -g | ||
|
|
||
| Parameters: | ||
|
|
||
| 1) bus: I3C bus number | ||
| 2) manufid: Manufacturer ID (upper 16 bits of device PID) | ||
| 3) partid: Part ID (middle 16 bits of device PID) | ||
| 4) <data_length>: Data length to read on this message | ||
|
|
||
| Note: The manufid and partid are extracted from the device's 48-bit Provisional | ||
| ID (PID). To find these values, first use the -g option to get device information, | ||
| then extract: | ||
| - manufid = (PID >> 32) & 0xFFFF | ||
| - partid = (PID >> 16) & 0xFFFF | ||
|
|
||
| # Example | ||
| 1. i3c -b 0 -m 0x01E0 -p 0x0001 -w 0xde | ||
| 2. i3c -b 0 -m 0x01E0 -p 0x0001 -w "0xde,0xad,0xbe,0xef" | ||
| 3. i3c -b 0 -m 0x01E0 -p 0x0001 -w "0xde,0xad" -w "0xbe,0xef" | ||
| 4. i3c -b 0 -m 0x01E0 -p 0x0001 -r 0x10 | ||
| 5. i3c -b 0 -m 0x01E0 -p 0x0001 -r 0x10 -r 0x10 | ||
| 6. i3c -b 0 -m 0x01E0 -p 0x0001 -w "0xde,0xad,0xbe,0xef" -r 0x10 | ||
| 7. i3c -b 0 -m 0x01E0 -p 0x0001 -g | ||
|
|
||
| # Migration from target_addr | ||
|
|
||
| Previous versions used `-d targetaddr` to specify the device address. The new | ||
| version uses `-m manufid -p partid` to identify devices by their unique PID. | ||
|
|
||
| To migrate: | ||
| 1. Get device PID using the old command (if available): | ||
| ``` | ||
| i3c -b 0 -d <addr> -g | ||
| ``` | ||
| Output: `i3c_device_info - pid 0x01E000010000XXXX` | ||
|
|
||
| 2. Extract manufid and partid from PID: | ||
| ``` | ||
| manufid = 0x01E0 (bits 47-32) | ||
| partid = 0x0001 (bits 31-16) | ||
| ``` | ||
|
|
||
| 3. Use new command format: | ||
| ``` | ||
| i3c -b 0 -m 0x01E0 -p 0x0001 -r 0x10 | ||
| ``` | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Donny9 README.md was deprecated in favor to reStructuredText used in nuttx/Documentation. Please move it to there