arch/risc-v/eic7700x: Add support for ESWIN EIC7700X SoC#15921
arch/risc-v/eic7700x: Add support for ESWIN EIC7700X SoC#15921hartmannathan merged 2 commits intoapache:masterfrom
Conversation
|
[Experimental Bot, please feedback here] Yes, this PR meets the NuttX requirements. The summary clearly explains the change, its purpose, and the affected files. The impact section adequately addresses the scope of the changes and confirms no impact on existing users, build processes, or other hardware. The testing section provides sufficient evidence of successful testing on the target hardware, including boot logs and the output of key commands like |
hartmannathan
left a comment
There was a problem hiding this comment.
Thanks for adding new arch support! Commit logs look good. Code is well-commented. I don't have this hardware to verify actual code but looks good on code reading.
…0X SoC This PR adds support for the ESWIN EIC7700X RISC-V SoC. This will be used by the upcoming port of NuttX for PINE64 StarPro64 SBC. Most of the code was derived from NuttX for SOPHGO SG2000 SoC. The modified code is explained here: https://lupyuen.github.io/articles/starpro64#appendix-port-nuttx-to-starpro64 platforms/risc-v/eic7700x/index.rst: Added EIC7700X SoC Signed-off-by: Lup Yuen Lee <luppy@appkaki.com>
This PR adds support for the ESWIN EIC7700X RISC-V SoC. This will be used by the upcoming port of NuttX for PINE64 StarPro64 SBC. Most of the code was derived from NuttX for SOPHGO SG2000 SoC. The modified code is explained here: https://lupyuen.github.io/articles/starpro64#appendix-port-nuttx-to-starpro64 Modified Files in arch/risc-v: Kconfig: Added ARCH_CHIP_EIC7700X for EIC7700X SoC New Files in arch/risc-v: include/eic7700x/chip.h: EIC7700X Definitions include/eic7700x/irq.h: External Interrupts src/eic7700x/chip.h: Interrupt Stack Macro src/eic7700x/eic7700x_allocateheap.c: Kernel Heap src/eic7700x/eic7700x_head.S: Linux Header and Boot Code src/eic7700x/eic7700x_irq.c: Configure Interrupts src/eic7700x/eic7700x_irq_dispatch.c: Dispatch Interrupts src/eic7700x/eic7700x_memorymap.h: Memory Map src/eic7700x/eic7700x_mm_init.c, eic7700x_mm_init.h: Memory Mgmt src/eic7700x/eic7700x_pgalloc.c: Page Allocator src/eic7700x/eic7700x_start.c: Startup Code src/eic7700x/eic7700x_timerisr.c: Timer Interrupt src/eic7700x/hardware/eic7700x_memorymap.h: PLIC and UART Base Address src/eic7700x/hardware/eic7700x_plic.h: PLIC Register Addresses src/eic7700x/Kconfig: EIC7700X Config src/eic7700x/Make.defs: Makefile Signed-off-by: Lup Yuen Lee <luppy@appkaki.com>
|
Maybe we should mark this change with |
|
Actually the typos we found above are also present in other RISC-V ports: QEMU, SG2000, BL808, K230, MPFS, ... So it's not an "Experimental" issue, more like a "Legacy" fix that needs backporting 😬 Update: I found 20 source files with the same typos, I submitted the PR here: |
This PR fixes the typos in chip.h, allocateheap.c and start.c. The typos were discovered here: - apache#15921 Signed-off-by: Lup Yuen Lee <luppy@appkaki.com>
This PR fixes the typos in the Code Comments of chip.h, allocateheap.c and start.c. The typos were discovered here: - apache#15921 Signed-off-by: Lup Yuen Lee <luppy@appkaki.com>
This PR fixes the typos in the Code Comments of chip.h, allocateheap.c and start.c. The typos were discovered here: - apache#15921 Signed-off-by: Lup Yuen Lee <luppy@appkaki.com>
This PR fixes the typos in the Code Comments of chip.h, allocateheap.c and start.c. The typos were discovered here: - #15921 Signed-off-by: Lup Yuen Lee <luppy@appkaki.com>
|
Sorry @hartmannathan: Are you OK if we merge the PR for ESWIN EIC7700X SoC? I corrected the typos (also for 20 other files). Thanks :-) |
@lupyuen Yes! LGTM, thanks for your patience, I merged it just now :-) |
This PR fixes the typos in the Code Comments of chip.h, allocateheap.c and start.c. The typos were discovered here: - apache#15921 Signed-off-by: Lup Yuen Lee <luppy@appkaki.com>
This PR fixes the typos in the Code Comments of chip.h, allocateheap.c and start.c. The typos were discovered here: - apache#15921 Signed-off-by: Lup Yuen Lee <luppy@appkaki.com>
This PR fixes the typos in the Code Comments of chip.h, allocateheap.c and start.c. The typos were discovered here: - apache#15921 Signed-off-by: Lup Yuen Lee <luppy@appkaki.com>
This PR fixes the typos in the Code Comments of chip.h, allocateheap.c and start.c. The typos were discovered here: - apache#15921 Signed-off-by: Lup Yuen Lee <luppy@appkaki.com>
This PR fixes the typos in the Code Comments of chip.h, allocateheap.c and start.c. The typos were discovered here: - apache#15921 Signed-off-by: Lup Yuen Lee <luppy@appkaki.com>
This PR fixes the typos in the Code Comments of chip.h, allocateheap.c and start.c. The typos were discovered here: - #15921 Signed-off-by: Lup Yuen Lee <luppy@appkaki.com>
Summary
This PR adds support for the ESWIN EIC7700X RISC-V SoC. This will be used by the upcoming port of NuttX for PINE64 StarPro64 SBC.
Most of the code was derived from NuttX for SOPHGO SG2000 SoC. The modified code is explained here
Modified Files in arch/risc-v
Kconfig: Added ARCH_CHIP_EIC7700X for EIC7700X SoCNew Files in arch/risc-v
include/eic7700x/chip.h: EIC7700X Definitionsinclude/eic7700x/irq.h: External Interruptssrc/eic7700x/chip.h: Interrupt Stack Macrosrc/eic7700x/eic7700x_allocateheap.c: Kernel Heapsrc/eic7700x/eic7700x_head.S: Linux Header and Boot Codesrc/eic7700x/eic7700x_irq.c: Configure Interruptssrc/eic7700x/eic7700x_irq_dispatch.c: Dispatch Interruptssrc/eic7700x/eic7700x_memorymap.h: Memory Mapsrc/eic7700x/eic7700x_mm_init.c,eic7700x_mm_init.h: Memory Mgmtsrc/eic7700x/eic7700x_pgalloc.c: Page Allocatorsrc/eic7700x/eic7700x_start.c: Startup Codesrc/eic7700x/eic7700x_timerisr.c: Timer Interruptsrc/eic7700x/hardware/eic7700x_memorymap.h: PLIC and UART Base Addresssrc/eic7700x/hardware/eic7700x_plic.h: PLIC Register Addressessrc/eic7700x/Kconfig: EIC7700X Configsrc/eic7700x/Make.defs: MakefileDocumentation
platforms/risc-v/eic7700x/index.rst: Added EIC7700X SoCImpact
This PR is needed for the upcoming port of NuttX for PINE64 StarPro64 SBC.
No impact on existing code, since the EIC7700X source files are not used by existing code.
Testing
We tested the EIC7700X source files on PINE64 StarPro64 SBC. NuttX boots correctly to NSH Shell and passes OSTest: