utils.h: add conn_dev_sem_timedwait interface to simplify code logic #17755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modify functions that are simple but frequently called into inline functions, thereby reducing CPU loading without significantly changing the code size. Signed-off-by: zhanghongyu <[email protected]>
the following code can be modified
conn_dev_unlock(&conn->sconn, conn->dev);
ret = net_sem_timedwait_uninterruptible(&conn->snd_sem,
tcp_send_gettimeout(start, timeout));
conn_dev_lock(&conn->sconn, conn->dev);
to
ret = conn_dev_sem_timedwait(&conn->snd_sem, false,
tcp_send_gettimeout(start, timeout), &conn->sconn, conn->dev);
Signed-off-by: zhanghongyu <[email protected]>
decouple lock dependencies from other modules. Signed-off-by: zhanghongyu <[email protected]>
decouple lock dependencies from other modules. Signed-off-by: zhanghongyu <[email protected]>
…being NULL thus supporting scenarios that only require break netdev_lock. Signed-off-by: zhanghongyu <[email protected]>
zhhyu7
requested review from
Donny9,
antmerlino,
btashton,
fjpanag,
gustavonihei,
jerpelea,
masayuki2009,
pkarashchenko,
xiaoxiang781216 and
yamt
as code owners
optimize the current code format according to the previous net_xxx_wait implementation to reduce multiple calls of similar code Signed-off-by: zhanghongyu <[email protected]>
jerpelea
approved these changes
Jan 2, 2026
acassis
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
optimize the current code format according to the previous net_xxx_wait implementation to reduce multiple calls of similar code.
Impact
wait process for holding locks in the protocol stack
Testing
sim:matter with ping and iperf
NuttX test log:
The low rate of the UDP RX process is due to the implementation mechanism of the sim network card in the simulator, which by default can only read data once every 10ms, and the buffer size of the host's tap network card limits this rate.