Open
Conversation
dosubot
bot
added
size:L
tisonkun
reviewed
Dec 22, 2025
bindings/java/src/main/java/org/apache/opendal/NativeLibrary.java
Outdated
Show resolved
Hide resolved
tisonkun
reviewed
Dec 22, 2025
tisonkun
reviewed
Dec 23, 2025
bindings/java/tools/build.py
Outdated
| ] | ||
| print("$ " + subprocess.list2cmdline(link_cmd)) | ||
| subprocess.run(link_cmd, cwd=basedir, check=True) | ||
| raise SystemExit(0) |
Member
Author
There was a problem hiding this comment.
It's a weird AI code. It's actually sys.exit(0) here. Refactored.
Member
There was a problem hiding this comment.
But it looks still incorrect. We need the following lines to move the output artifacts.
tisonkun
reviewed
Dec 23, 2025
| if (loader == null) { | ||
| return false; | ||
| } | ||
| return Files.exists(Paths.get("/lib", loader)) || Files.exists(Paths.get("/usr/lib", loader)); |
Member
There was a problem hiding this comment.
Did you test this line works?
I suspect that with bundled jar the file doesn't exist on /lib but in the JAR package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7086
Rationale for this change
This PR will add musl platform support for binding java.
What changes are included in this PR?
Are there any user-facing changes?
AI Usage Statement
Parts of this PR were drafted with assistance from Codex (with
gpt-5.2) and fully reviewed and edited by me. I take full responsibility for all changes.