feat(hf): support writing and reading from both http and xet#7185
Open
kszucs wants to merge 20 commits intoapache:mainfrom
Open
feat(hf): support writing and reading from both http and xet#7185kszucs wants to merge 20 commits intoapache:mainfrom
kszucs wants to merge 20 commits intoapache:mainfrom
Conversation
dosubot
bot
added
size:XXL
tisonkun
reviewed
Feb 11, 2026
tisonkun
reviewed
Feb 11, 2026
tisonkun
reviewed
Feb 11, 2026
tisonkun
reviewed
Feb 11, 2026
tisonkun
reviewed
Feb 11, 2026
| #[serde(default)] | ||
| #[non_exhaustive] | ||
| pub struct HuggingfaceConfig { | ||
| pub struct HfConfig { |
Member
There was a problem hiding this comment.
Maybe do the rename in a separate PR?
Member
There was a problem hiding this comment.
You can open one now. We can merge it, and you can rebase this PR onto that merged one. Then we have fewer changesets to review.
I have no strong feelings about either name. But this can be a breaking change that needs to be documented.
Member
Author
|
I'm still working on a couple of things, like implementing oio::Write instead of OneShotWrite which requires some additional changes in my xet-core PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Work-in-progress, but generally:
I opened the PR for better visibility and early feedback.
Depends on huggingface/xet-core#642
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
AI Usage Statement