Conversation
35f99d7 to
9e02e12
Compare
e440c2a to
e7ae840
Compare
- modernizes xml files of the OpenNLP dev manual to use Docbook dtd in version 5.x - adds plugin configuration to produce the PDF as separate outcome - adds xsl file for customization of the layout of text in the PDF - adds hyphenation support for PDF and epub versions - introduces specific profiles for html, pdf, and epub3 targets of the dev manual - adds cover entry to opennlp.xml for epub target - fixes inconsistencies in dev manual's structure (duplicate ids...) - fixes 'informaltable' column counts, mainly in cli.xml - fixes missing inlinemediaobject for parsetree1.png image include causing trouble during epub3 generation - adds config for pdf and epub file inclusion to bin.xml config in opennlp-distr/assembly
e7ae840 to
50461bf
Compare
Contributor
Author
|
Note: I ran checks for the resulting epub file (German output)
So it seems, epubcheck is telling us, we create a valid EBook for the OpenNLP dev manual, including a cover image. |
jzonthemtn
approved these changes
Jan 18, 2026
- modernizes xml files of the OpenNLP dev manual to use Docbook dtd in version 5.x - adds plugin configuration to produce the PDF as separate outcome - adds xsl file for customization of the layout of text in the PDF - adds hyphenation support for PDF and epub versions - introduces specific profiles for html, pdf, and epub3 targets of the dev manual - adds cover entry to opennlp.xml for epub target - fixes inconsistencies in dev manual's structure (duplicate ids...) - fixes 'informaltable' column counts, mainly in cli.xml - fixes missing inlinemediaobject for parsetree1.png image include causing trouble during epub3 generation - adds config for pdf and epub file inclusion to bin.xml config in opennlp-distr/assembly
mawiesne
added a commit
that referenced
this pull request
Jan 22, 2026
…920) * OPENNLP-1792: Add docbkx plugin config to produce PDF of dev manual - modernizes xml files of the OpenNLP dev manual to use Docbook dtd in version 5.x - adds plugin configuration to produce the PDF as separate outcome - adds xsl file for customization of the layout of text in the PDF - adds hyphenation support for PDF and epub versions - introduces specific profiles for html, pdf, and epub3 targets of the dev manual - adds cover entry to opennlp.xml for epub target - fixes inconsistencies in dev manual's structure (duplicate ids...) - fixes 'informaltable' column counts, mainly in cli.xml - fixes missing inlinemediaobject for parsetree1.png image include causing trouble during epub3 generation - adds config for pdf and epub file inclusion to bin.xml config in opennlp-distr/assembly (cherry picked from commit 58d91f0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
OPENNLP-1792: Add docbkx plugin config to produce PDF of dev manual
opennlp-distr/assemblyHow to reproduce on local machine
cd opennlp-docsmvn clean verify -Pdocs-manual-html -Pdocs-manual-pdf -Pdocs-manual-epubtarget/docbkxfor sub directoriespdf,html, and separateopennlp.epubfile.Tasks
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.