Skip to content

OPENNLP-1801: Extract eval tests into separate opennlp-eval-tests module#980

Merged
mawiesne merged 2 commits intomainfrom
OPENNLP-1801
Mar 20, 2026
Merged

OPENNLP-1801: Extract eval tests into separate opennlp-eval-tests module#980
mawiesne merged 2 commits intomainfrom
OPENNLP-1801

Conversation

@rzo1
Copy link
Copy Markdown
Contributor

@rzo1 rzo1 commented Mar 19, 2026

as the title says

@rzo1 rzo1 requested a review from mawiesne March 19, 2026 08:46
@mawiesne
Copy link
Copy Markdown
Contributor

mawiesne commented Mar 19, 2026 •
edited
Loading

I've kicked: https://ci-builds.apache.org/job/OpenNLP/job/eval-tests-configurable/37/

@mawiesne mawiesne added tests Pull requests that add or update test code build Pull requests that update the build chain. and removed tests Pull requests that add or update test code labels Mar 19, 2026
@mawiesne mawiesne requested a review from jzonthemtn March 19, 2026 09:43
@mawiesne
Copy link
Copy Markdown
Contributor

mawiesne commented Mar 19, 2026

I've kicked: https://ci-builds.apache.org/job/OpenNLP/job/eval-tests-configurable/37/

This one failed due to missing resource files in lang/...

@jzonthemtn
Copy link
Copy Markdown
Contributor

jzonthemtn commented Mar 19, 2026

Just curious, what's the benefit of this?

@mawiesne mawiesne marked this pull request as draft March 19, 2026 12:54
@rzo1
Copy link
Copy Markdown
Contributor Author

rzo1 commented Mar 19, 2026

Just curious, what's the benefit of this?

Separation of concerns — Unit/integration tests (fast, self-contained) stay in their modules. Easier surefire config (no exclude phases)

@mawiesne
Copy link
Copy Markdown
Contributor

mawiesne commented Mar 19, 2026

CI Build with Eval with recent changes:
https://ci-builds.apache.org/job/OpenNLP/job/eval-tests-configurable/38/

@mawiesne mawiesne marked this pull request as ready for review March 19, 2026 16:08
@mawiesne
Copy link
Copy Markdown
Contributor

mawiesne commented Mar 20, 2026

CI Build with Eval with recent changes: https://ci-builds.apache.org/job/OpenNLP/job/eval-tests-configurable/38/

[INFO] Apache OpenNLP :: Eval Tests ....................... SUCCESS [  04:05 h]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  04:37 h
[INFO] Finished at: 2026-03-19T18:16:39Z

@mawiesne mawiesne merged commit 1270fdb into main Mar 20, 2026
9 checks passed
@mawiesne mawiesne deleted the OPENNLP-1801 branch March 20, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mawiesne mawiesne mawiesne approved these changes

@jzonthemtn jzonthemtn Awaiting requested review from jzonthemtn

Assignees

@rzo1 rzo1

Labels

build Pull requests that update the build chain. tests Pull requests that add or update test code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rzo1 @mawiesne @jzonthemtn