ORC-1884: [C++] Add a maybe() API to the SearchArgumentBuilder#2207
ORC-1884: [C++] Add a maybe() API to the SearchArgumentBuilder#2207luffy-zh wants to merge 2 commits intoapache:mainfrom
Conversation
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you for making a PR.
For the following claims, It seems unclear to me because there is no actual test case.
Allow the insertion of an expression tree that is currently unsupported.
I'd like to recommend the following.
- Revert the change on the existing test case.
- Add a new test case which shows the claim, "the insertion of an expression tree that is currently unsupported".
In general, your new test case should verify your code contribution. For example, the new test case should fail without your patch. AFAIK, this PR only adds .maybe() to the existing successful test cases. So, it's improper to validate this PR's contribution.
|
Is |
|
|
Hi, Yuanping (@ffacs), if you think it's okay, you can merge this. Feel free to merge this PR because I removed my review here. 😄 |
|
Let me merge this. |
|
Thank you, @luffy-zh and all. |
What changes were proposed in this pull request?
Add a maybe() API to the SearchArgumentBuilder to allow the insertion of an expression tree that is currently unsupported.
Why are the changes needed?
To enhance the SearchArgumentBuilder API with a new method called maybe(), we can create a SearchArgument tree for scenarios that may not be adequately addressed by existing methods.
How was this patch tested?
Uts in TestSearchArgument.cc can cover this patch.
Was this patch authored or co-authored using generative AI tooling?
NO