ORC-2022: [C++] Add support to use dictionary for IN expression #2453
Closed
luffy-zh wants to merge 13 commits intoapache:mainfrom
Closed
ORC-2022: [C++] Add support to use dictionary for IN expression #2453luffy-zh wants to merge 13 commits intoapache:mainfrom
luffy-zh wants to merge 13 commits intoapache:mainfrom
Conversation
added 6 commits
October 24, 2025 16:44
ffacs
reviewed
Oct 28, 2025
ffacs
reviewed
Oct 29, 2025
…e set of literals.
ffacs
reviewed
Oct 31, 2025
c++/src/sargs/SargsApplier.cc
Outdated
| size_t dictSize = dictionary.dictionaryOffset.size() - 1; | ||
|
|
||
| // Use a set to store matching dictionary entries | ||
| std::set<size_t> matchingDictEntries; |
ffacs
approved these changes
Nov 3, 2025
wgtmac
approved these changes
Nov 3, 2025
wgtmac
reviewed
Nov 5, 2025
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use column dictionaries to evaluate IN predicates.
Why are the changes needed?
Optimize IN predicate pruning: consult column dictionary (when reasonably sized) instead of relying on less effective min/max statistics.
How was this patch tested?
Unit tests in TestPredicatePushdown.cc verify this change.
Was this patch authored or co-authored using generative AI tooling?
NO.