Skip to content

Conversation

@jojochuang
Copy link
Contributor

What changes were proposed in this pull request?

HDDS-11929. [Website v2] [Docs] [Administrator Guide] Tracking Metrics With Prometheus.

Migrate the Prometheus section of this doc https://ozone.apache.org/docs/edge/feature/observability.html to https://ozone-site-v2.staged.apache.org/docs/administrator-guide/operations/observability/prometheus

What is the link to the Apache Jira?

https://issues.apache.org/jira/browse/HDDS-11929

How was this patch tested?

Previewed locally.

Screenshot 2024-12-13 at 11 45 18 AM

@github-actions github-actions bot added the website-v2 Tasks for the new ozone website targeting the HDDS-9225-website-v2 branch label Dec 13, 2024
@jojochuang
Copy link
Contributor Author

not sure what to do to skip these spelling checks.

./docs/05-administrator-guide/03-operations/09-observability/04-prometheus.md:34:11     - Unknown word (putyourtokenhere) -- <value>putyourtokenhere</value>
./docs/05-administrator-guide/03-operations/09-observability/04-prometheus.md:43:20     - Unknown word (putyourtokenhere) -- bearer_token: <putyourtokenhere>

@errose28 errose28 added the docs Changes updating documentation on the website label Dec 16, 2024
@jojochuang jojochuang closed this Jul 25, 2025
@jojochuang jojochuang reopened this Dec 18, 2025
Comment on lines +4 to +19
<!---
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue here as well - #112 (comment)
Please remove the license comment.

@smengcl
Copy link
Contributor

smengcl commented Jan 6, 2026

not sure what to do to skip these spelling checks.

./docs/05-administrator-guide/03-operations/09-observability/04-prometheus.md:34:11     - Unknown word (putyourtokenhere) -- <value>putyourtokenhere</value>
./docs/05-administrator-guide/03-operations/09-observability/04-prometheus.md:43:20     - Unknown word (putyourtokenhere) -- bearer_token: <putyourtokenhere>

I don't see this in CI anymore. Is it fixed on CI side?

Copy link
Contributor

@smengcl smengcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jojochuang

Other than #111 (comment) , lgtm

@jojochuang
Copy link
Contributor Author

That spelling check message doesn't reproduce locally. I just rebased my PR and it's not seen in CI either.

@jojochuang jojochuang merged commit 2c2f6cc into apache:HDDS-9225-website-v2 Jan 7, 2026
11 checks passed
@jojochuang
Copy link
Contributor Author

Merged. Thanks @smengcl and @sarvekshayr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Changes updating documentation on the website website-v2 Tasks for the new ozone website targeting the HDDS-9225-website-v2 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants