-
Notifications
You must be signed in to change notification settings - Fork 593
HDDS-14293. Improve Dynamic Property Reload documentation #9582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sreejasahithi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vyalamar for working on this, left few comments
- Added ozone.readonly.administrators to OM and SCM - Added ozone.key.deleting.limit.per.task to OM - Added ozone.directory.deleting.service.interval to OM - Added ozone.thread.number.dir.deletion to OM - Added ozone.snapshot.filtering.service.interval to OM - Added hdds.datanode.block.delete.threads.max to Datanode - Added ozone.block.deleting.service.workers to Datanode - Added ozone.block.deleting.service.interval to Datanode - Added ozone.block.deleting.service.timeout to Datanode - Added hdds.datanode.replication.streams.limit to Datanode
|
@sreejasahithi Can you please check. I have addressed all your comments. |
|
@sreejasahithi Can you please look into apache/ozone-site#217 |
sreejasahithi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vyalamar for updating the patch. Left few minor comments
Could you please also add in the doc that --address must be specified if --in-service-datanodes is not given.(even though your examples do show this)
Co-authored-by: sreejasahithi <[email protected]>
- Updated --address to accept both IP and hostname formats - Clarified that --address is required unless --in-service-datanodes is specified
|
@sreejasahithi please help merge this PR. |
|
@umamaheswararao @sreejasahithi Can you please help merge the PR. |
jojochuang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. thanks for the update.
Found a few properties not in my Ozone 2.1 build, only added recently.
| | `hdds.scm.replication.datanode.reconstruction.weight` | `3` | Weight multiplier for reconstruction commands | | ||
| | `hdds.scm.replication.datanode.delete.container.limit` | `40` | Max delete container commands queued per datanode | | ||
| | `hdds.scm.replication.inflight.limit.factor` | `0.75` | Factor to scale cluster-wide replication limit | | ||
| | `hdds.scm.replication.container.sample.limit` | `100` | Number of containers sampled per state for debugging | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a few days ago in the https://issues.apache.org/jira/browse/HDDS-5713 disk balancer branch.
| | `ozone.readonly.administrators` | - | Comma-separated list of read-only administrators | | ||
| | `ozone.om.server.list.max.size` | `1000` | Maximum server-side response size for list operations | | ||
| | `ozone.om.volume.listall.allowed` | `true` | Allow all users to list all volumes | | ||
| | `ozone.om.follower.read.local.lease.enabled` | `false` | Enable local lease for follower read optimization | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added recently by HDDS-13954
| | `ozone.om.server.list.max.size` | `1000` | Maximum server-side response size for list operations | | ||
| | `ozone.om.volume.listall.allowed` | `true` | Allow all users to list all volumes | | ||
| | `ozone.om.follower.read.local.lease.enabled` | `false` | Enable local lease for follower read optimization | | ||
| | `ozone.om.follower.read.local.lease.lag.limit` | `10000` | Maximum log lag for follower reads | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added recently by HDDS-13954
|
@jojochuang who can merge this? And secondly can I have the slack handle please. |
|
Merged. Thanks @vyalamar @sreejasahithi . I sent an invite to join the ASF slack |
What changes were proposed in this pull request?
This PR improves the Dynamic Property Reload (Reconfigurability) documentation:
ozone.administrators)ozone.example.configwith actual DataNode propertyhdds.datanode.block.deleting.limit.per.intervalWhat is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14293
How was this patch tested?
This is a documentation-only change. Verified that the markdown renders correctly locally.