Skip to content

Conversation

@vyalamar
Copy link
Contributor

@vyalamar vyalamar commented Jan 5, 2026

What changes were proposed in this pull request?

This PR improves the Dynamic Property Reload (Reconfigurability) documentation:

  1. Renamed title from "Reconfigurability" to "Dynamic Property Reload" per the JIRA task
  2. Added comprehensive reference tables listing all reconfigurable properties for OM, SCM, and DataNode (previously only showed ozone.administrators)
  3. Fixed typo in SCM section (incorrectly showed "Started OM reconfiguration" instead of "Started reconfiguration")
  4. Replaced placeholder ozone.example.config with actual DataNode property hdds.datanode.block.deleting.limit.per.interval
  5. Added Best Practices section for operators
  6. Improved formatting with proper markdown tables and code blocks
  7. Updated Chinese translation with the same placeholder fix

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-14293

How was this patch tested?

This is a documentation-only change. Verified that the markdown renders correctly locally.

Copy link
Contributor

@sreejasahithi sreejasahithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vyalamar for working on this, left few comments

sreejasahithi

This comment was marked as duplicate.

- Added ozone.readonly.administrators to OM and SCM
- Added ozone.key.deleting.limit.per.task to OM
- Added ozone.directory.deleting.service.interval to OM
- Added ozone.thread.number.dir.deletion to OM
- Added ozone.snapshot.filtering.service.interval to OM
- Added hdds.datanode.block.delete.threads.max to Datanode
- Added ozone.block.deleting.service.workers to Datanode
- Added ozone.block.deleting.service.interval to Datanode
- Added ozone.block.deleting.service.timeout to Datanode
- Added hdds.datanode.replication.streams.limit to Datanode
@vyalamar
Copy link
Contributor Author

vyalamar commented Jan 5, 2026

@sreejasahithi Can you please check. I have addressed all your comments.

@vyalamar
Copy link
Contributor Author

vyalamar commented Jan 5, 2026

@sreejasahithi Can you please look into apache/ozone-site#217

@adoroszlai adoroszlai added the documentation Improvements or additions to documentation label Jan 5, 2026
Copy link
Contributor

@sreejasahithi sreejasahithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vyalamar for updating the patch. Left few minor comments

Could you please also add in the doc that --address must be specified if --in-service-datanodes is not given.(even though your examples do show this)

vyalamar and others added 2 commits January 9, 2026 11:18
- Updated --address to accept both IP and hostname formats
- Clarified that --address is required unless --in-service-datanodes is specified
@vyalamar
Copy link
Contributor Author

vyalamar commented Jan 9, 2026

@sreejasahithi please help merge this PR.

@vyalamar
Copy link
Contributor Author

vyalamar commented Jan 9, 2026

@umamaheswararao @sreejasahithi Can you please help merge the PR.

Copy link
Contributor

@jojochuang jojochuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks for the update.
Found a few properties not in my Ozone 2.1 build, only added recently.

| `hdds.scm.replication.datanode.reconstruction.weight` | `3` | Weight multiplier for reconstruction commands |
| `hdds.scm.replication.datanode.delete.container.limit` | `40` | Max delete container commands queued per datanode |
| `hdds.scm.replication.inflight.limit.factor` | `0.75` | Factor to scale cluster-wide replication limit |
| `hdds.scm.replication.container.sample.limit` | `100` | Number of containers sampled per state for debugging |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few days ago in the https://issues.apache.org/jira/browse/HDDS-5713 disk balancer branch.

| `ozone.readonly.administrators` | - | Comma-separated list of read-only administrators |
| `ozone.om.server.list.max.size` | `1000` | Maximum server-side response size for list operations |
| `ozone.om.volume.listall.allowed` | `true` | Allow all users to list all volumes |
| `ozone.om.follower.read.local.lease.enabled` | `false` | Enable local lease for follower read optimization |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added recently by HDDS-13954

| `ozone.om.server.list.max.size` | `1000` | Maximum server-side response size for list operations |
| `ozone.om.volume.listall.allowed` | `true` | Allow all users to list all volumes |
| `ozone.om.follower.read.local.lease.enabled` | `false` | Enable local lease for follower read optimization |
| `ozone.om.follower.read.local.lease.lag.limit` | `10000` | Maximum log lag for follower reads |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added recently by HDDS-13954

@vyalamar
Copy link
Contributor Author

vyalamar commented Jan 9, 2026

@jojochuang who can merge this? And secondly can I have the slack handle please.

@jojochuang jojochuang merged commit 7cd8e48 into apache:master Jan 9, 2026
15 checks passed
@jojochuang
Copy link
Contributor

Merged. Thanks @vyalamar @sreejasahithi . I sent an invite to join the ASF slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants