[cdc] Support audit time computed clumns during cdc sync database#5069
Closed
JackeyLee007 wants to merge 115 commits intoapache:masterfrom
Closed
[cdc] Support audit time computed clumns during cdc sync database#5069JackeyLee007 wants to merge 115 commits intoapache:masterfrom
JackeyLee007 wants to merge 115 commits intoapache:masterfrom
Conversation
wwj6591812
reviewed
Feb 13, 2025
| @Override | ||
| protected void beforeBuildingSourceSink() throws Exception { | ||
| computedColumns = | ||
| buildComputedColumns(computedColumnArgs, Arrays.asList(SpecialFields.VALUE_KIND)); |
Contributor
There was a problem hiding this comment.
Collections.singletonList(SpecialFields.VALUE_KIND)
| protected String includingTables = ".*"; | ||
| protected List<String> partitionKeys = new ArrayList<>(); | ||
| protected List<String> primaryKeys = new ArrayList<>(); | ||
| protected boolean auditTimeEnabled = false; |
Contributor
There was a problem hiding this comment.
where auditTimeEnabled used?
| protected List<String> partitionKeys = new ArrayList<>(); | ||
| protected List<String> primaryKeys = new ArrayList<>(); | ||
| protected boolean auditTimeEnabled = false; | ||
| protected List<String> computedColumnArgs = new ArrayList<>(); |
Contributor
There was a problem hiding this comment.
I think computedColumns is better?
| computedColumn.eval(rowData.get(computedColumn.fieldReference()))); | ||
| String argVal; | ||
| if (computedColumn.fieldReference().equals(SpecialFields.VALUE_KIND.name())) { | ||
| argVal = rowKind.shortString(); |
Contributor
There was a problem hiding this comment.
if (Objects.equals(computedColumn.fieldReference(), SpecialFields.VALUE_KIND.name()))
| LONGTEXT_TO_BYTES, | ||
| BIGINT_UNSIGNED_TO_BIGINT; | ||
| BIGINT_UNSIGNED_TO_BIGINT, | ||
| DECIMAL_NO_CHANGE, |
Contributor
There was a problem hiding this comment.
Add the note of DECIMAL_NO_CHANGE and NO_CHANGE before this enum.
…fault aggregator in partial update (apache#4897)
…ifests system table (apache#4922)
…try In RESTCatalog (apache#4929)
…TIME ZONE in data-types (apache#5053)
… of hive queries (apache#5060)
…ve engines to get the token (apache#5063)
… of relative table path (apache#5051)
…ink procedure and action (apache#4878) This closes apache#4878.
…ions create_time() and update_time() to compute according to rowkind
JackeyLee007
force-pushed
the
audit-time-clean
branch
from
a21734d to
4e03fd3
Compare
Contributor
Author
|
@wwj6591812 Thanks for your review yesterday. I re-compose a new clean PR #5086. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #5068
Support special audition computed columns, especially for cdc sync database
Tests
org.apache.paimon.flink.action.cdc.kafka.KafkaCanalSyncDatabaseActionITCase#testAuditTime
API and Format
Documentation