[core] Enables buffer spill when targetFileSize is greater than the w…#5121
Merged
JingsongLi merged 1 commit intoapache:masterfrom Feb 28, 2025
Merged
Conversation
LinMingQiang
force-pushed
the
master-imp-enable-spill
branch
from
b660631 to
6aa7a03
Compare
JingsongLi
reviewed
Feb 20, 2025
wwj6591812
reviewed
Feb 24, 2025
LinMingQiang
force-pushed
the
master-imp-enable-spill
branch
2 times, most recently
from
a5df99f to
ef100eb
Compare
LinMingQiang
force-pushed
the
master-imp-enable-spill
branch
from
ef100eb to
d614a92
Compare
Contributor
Author
|
ut failure is not caused by this pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rite buffer size.
Purpose
The purpose of this PR is to reduce small files.
When I set
target-file-size=1GBandwrite-buffer-for-append=true, write-buffer-size=256m,I found that my final file size is always smaller than
write-buffer-size=256mand will never reach the 1gb I expected.This resulted in a lot of small files being generated.
So when
target-file-sizeis greater thanwrite-buffer-size, spill should be enabled automatically.Linked issue: close #xxx
Tests
API and Format
Documentation