[core] Introduce DelayedLookupCompactManager to support delayed lookup compaction #5139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangyuf
force-pushed
the
delayed_lookup
branch
from
da906e9 to
56972a9
Compare
xiangyuf
force-pushed
the
delayed_lookup
branch
from
56972a9 to
3030d4e
Compare
wwj6591812
reviewed
Feb 24, 2025
paimon-core/src/main/java/org/apache/paimon/mergetree/compact/DelayedLookupCompactManager.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/append/AppendOnlyWriter.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/mergetree/compact/DelayedLookupCompactManager.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/mergetree/compact/DelayedLookupCompactManager.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/mergetree/compact/DelayedLookupCompactManager.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/mergetree/compact/DelayedLookupCompactManager.java
Outdated
Show resolved
Hide resolved
Contributor
|
@xiangyuf |
Contributor
Author
|
@wwj6591812 yes, the updates are uploaded from mobile devices. It is very common the updates are out of order for more than one week. |
xiangyuf
force-pushed
the
delayed_lookup
branch
3 times, most recently
from
c222ce9 to
5b3f946
Compare
Contributor
Author
|
@wwj6591812 Thx for review. All comments are resolved. |
xiangyuf
force-pushed
the
delayed_lookup
branch
from
5b3f946 to
0e8eed9
Compare
Contributor
Author
|
CI passed in local repo.
|
Contributor
Author
|
@wwj6591812 @JingsongLi PTAL |
Contributor
Author
Contributor
|
Close this in favor of #5178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #4917
Introduce DelayedLookupCompactManager to support delayed lookup compaction
Tests
DelayedLookupCompactManagerTest#testDelayedLookupCompactionBeforeThreshold
DelayedLookupCompactManagerTest#testDelayedLookupCompactionAfterThreshold
KeyValueFileStoreWriteTest#testDelayedLookupPartition
WriterOperatorTest#testDelayedLookupWithFailure
API and Format
Introduce hasDelayedCompact() in RecordWriter and CompactManager
Documentation