Skip to content

[core] Support in memory catalog for test RESTCatalog #5154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JingsongLi merged 7 commits into from
Feb 26, 2025
Merged

[core] Support in memory catalog for test RESTCatalog #5154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bcfef8f
support in memory catalog for test
jerry-024 Feb 25, 2025
715c9d9
Merge branch 'master' into rest-catalog
jerry-024 Feb 25, 2025
c276a39
remove logic in RESTCatalogServer
jerry-024 Feb 26, 2025
4adba63
commit
jerry-024 Feb 26, 2025
c13a2b2
rest catalog support alter database test
jerry-024 Feb 26, 2025
06218f7
Merge branch 'apache:master' into rest-catalog
jerry-024 Feb 26, 2025
126b875
fix
jerry-024 Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion paimon-core/src/main/java/org/apache/paimon/catalog/AbstractCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ public void alterDatabase(String name, List<PropertyChange> changes, boolean ign
if (changes == null || changes.isEmpty()) {
return;
}
alterDatabaseImpl(name, changes);
this.alterDatabaseImpl(name, changes);
} catch (DatabaseNotExistException e) {
if (ignoreIfNotExists) {
return;
Expand Down
3 changes: 2 additions & 1 deletion paimon-core/src/main/java/org/apache/paimon/catalog/FileSystemCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ protected void dropDatabaseImpl(String name) {
}

@Override
protected void alterDatabaseImpl(String name, List<PropertyChange> changes) {
protected void alterDatabaseImpl(String name, List<PropertyChange> changes)
throws DatabaseNotExistException {
throw new UnsupportedOperationException("Alter database is not supported.");
}

Expand Down
6 changes: 3 additions & 3 deletions paimon-core/src/main/java/org/apache/paimon/rest/RESTCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,9 +241,9 @@ public void alterDatabase(String name, List<PropertyChange> changes, boolean ign
request,
AlterDatabaseResponse.class,
restAuthFunction);
if (response.getUpdated().isEmpty()) {
throw new IllegalStateException("Failed to update properties");
}
// if (response.getUpdated().isEmpty()) {
// throw new IllegalStateException("Failed to update properties");
// }
} catch (NoSuchResourceException e) {
if (!ignoreIfNotExists) {
throw new DatabaseNotExistException(name);
Expand Down
Loading