[core]Support enums without spaces in TagPeriodFormatter #5165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I302587dd0f907b6cf9977fbaf7d7b983b66a0fba
Contributor
|
Great speed! |
xiangyuf
reviewed
Feb 26, 2025
| WITH_DASHES("with_dashes", "Dates and hours with dashes, e.g., 'yyyy-MM-dd HH'"), | ||
| WITHOUT_DASHES("without_dashes", "Dates and hours without dashes, e.g., 'yyyyMMdd HH'"); | ||
| WITHOUT_DASHES("without_dashes", "Dates and hours without dashes, e.g., 'yyyyMMdd HH'"), | ||
| WITH_DASHES_WITHOUT_SPACES( |
Contributor
There was a problem hiding this comment.
I'm don't think any user need this mode, yyyy-MM-ddHH . Looks weird. Maybe yyyyMMddHH is enough.
Contributor
Author
There was a problem hiding this comment.
Thanks for your suggestion, I've delete it.
Change-Id: I48dcb32ff0a07654c3ded2b47c9fcac8254c39f0
chenxinwei
force-pushed
the
master_suppert_tag_period_without_spaces
branch
from
53f82fa to
52a0f63
Compare
Change-Id: I27358ad0af4f1528de8ea8ad1613702c562cb557
Contributor
|
@chenxinwei Can CI passed in your local repo? |
Contributor
|
The code change LGTM. |
Contributor
Author
Yes |
Contributor
|
cc: @JingsongLi @wwj6591812 for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Hourly tag format only supports yyyy-MM-dd HH and yyyyMMdd HH now, user also need format without space.
Linked issue: close #5161
Support enums without spaces in TagPeriodFormatter.
Tests
Add testTagHourlyPeriodFormatterWithoutDashesAndSpaces in TagAutoManagerTest.java
API and Format
Documentation