[rest] Implement SupportsBranches in REST Catalog #5168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerry-024
reviewed
Feb 27, 2025
| request, | ||
| restAuthFunction); | ||
| } catch (NoSuchResourceException e) { | ||
| throw new TableNotExistException(identifier); |
Contributor
There was a problem hiding this comment.
Maybe the database or the tag does not exist?
| identifier.getDatabaseName(), identifier.getTableName(), branch), | ||
| restAuthFunction); | ||
| } catch (NoSuchResourceException e) { | ||
| throw new TableNotExistException(identifier); |
Contributor
There was a problem hiding this comment.
Maybe the branch does not exist?
| request, | ||
| restAuthFunction); | ||
| } catch (NoSuchResourceException e) { | ||
| throw new TableNotExistException(identifier); |
Contributor
There was a problem hiding this comment.
Maybe the branch or the database does not exist?
| } | ||
| return response.branches(); | ||
| } catch (NoSuchResourceException e) { | ||
| throw new TableNotExistException(identifier); |
Contributor
There was a problem hiding this comment.
Maybe the database does not exist?
Contributor
Author
There was a problem hiding this comment.
We should not have this exception. According to the current design, we only need to check the upper level exception when creating xx and listing xx (the upper level of branch is table)
| } | ||
|
|
||
| public String branches(String databaseName, String tableName) { | ||
| return SLASH.join(V1, prefix, DATABASES, databaseName, TABLES, tableName, "branches"); |
Contributor
There was a problem hiding this comment.
make "branches" like TABLES
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Next PR for #5157
Tests
API and Format
Documentation