Draft: support spark v2 write #5241
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zouxxyy
reviewed
Mar 10, 2025
| import java.io.Serializable; | ||
|
|
||
| /** Wrapper of Spark {@link InternalRow}. */ | ||
| public class SparkInternalRowWrapper implements org.apache.paimon.data.InternalRow, Serializable { |
Contributor
There was a problem hiding this comment.
Oh, it looks like #5159 has some duplicated work.
Contributor
Author
There was a problem hiding this comment.
Yea, I'll rebase once it's merged.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: part of #4816
Support spark datasource v2 write path, reduce write serialization overhead and accelerate the process of writing to primary key tables in Spark. Currently only added support for fixed-bucket table.
Tests
BucketFunctionTest, SparkWriteITCase
PaimonSourceWriteBenchmark：
API and Format
Documentation
Add a config
spark.sql.paimon.use-v2-writeto enable switching to v2 write, will fall back to v1 write when encountering an unsupported scenario(e.g.HASH_DYNAMICbucket mode table).Note: this is an overall draft PR, which will be split into smaller PRs for easier review.